From: Kees Cook <keescook@chromium.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
linux-hardening@vger.kernel.org, ocfs2-devel@lists.linux.dev,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH v2] fs: ocfs2: Replace strlcpy with sysfs_emit
Date: Thu, 31 Aug 2023 14:04:48 -0700 [thread overview]
Message-ID: <202308311404.875ABB0A@keescook> (raw)
In-Reply-To: <20230831193827.1528867-1-azeemshaikh38@gmail.com>
On Thu, Aug 31, 2023 at 07:38:27PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with sysfs_emit().
>
> Direct replacement is safe here since its ok for `kernel_param_ops.get()`
> to return -errno [3].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
> [3] https://elixir.bootlin.com/linux/v6.5/source/include/linux/moduleparam.h#L52
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-08-31 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 19:38 [PATCH v2] fs: ocfs2: Replace strlcpy with sysfs_emit Azeem Shaikh
2023-08-31 21:04 ` Kees Cook [this message]
2023-09-13 3:47 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308311404.875ABB0A@keescook \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox