From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9BB52D605 for ; Tue, 24 Oct 2023 21:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ecZEhEWN" Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9670FD7A for ; Tue, 24 Oct 2023 14:50:08 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1c9e06f058bso1818845ad.0 for ; Tue, 24 Oct 2023 14:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1698184208; x=1698789008; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kUk/3FUrTP2O4nxINnBvX1NoZwU7c4mrwIneHTDtXz8=; b=ecZEhEWNeFWjXXZhmpUQxqgQXST3Pc9zkLw3mrVneHts2vbd/VahNRRr8KbUiSEN4g zsrzSYlJvaUxjgdvNncP533jdFysu9Uv1t2Mqt7/V+ysQmbSghDEKQA+0qXpSz1FV1Yw U4EKIt+Hk7tBzbH9Bw8fEYCpv7y2cxaWN5tQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698184208; x=1698789008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kUk/3FUrTP2O4nxINnBvX1NoZwU7c4mrwIneHTDtXz8=; b=v7TgPYMFxdZW9j+1ozdqPfhc/Q0DcQQZ3uAJiGkS7dFQrH/sm5KSHNMvV16s4bR2UW rKiOR8oTR/XGw7ges6OdkysGult7ZJ8HoxwpF7VO7Mw9l4tZUMhyXYWcNxOmqI9mi/5q PvuPsdKWKx5bNn85fJ+SaH82qV2pkClulUxyFphKJf4WGVz4kjtV4HFqbPzgU3YL2y5K Z528N3XcvHJse0GjdgahJa9Gkl4WYmrPVnKvaVQL5A62vInFRj41hXdVRUMTqKgEituj mJfYz8bJlrdscfbZOeZz5Aq+Us1iryJxkVWaA6i/BAUaJLaFqmIwBDis/8GEhgT1OXLg vwcg== X-Gm-Message-State: AOJu0YwgeuA5kMBxhOCSgrPc6SJpZLlRmPgmguKeY9UN9PNfwWImjlXd MxjQkkXjlObY1TJu5kcbiYoJCw== X-Google-Smtp-Source: AGHT+IF9lyQ5nSycCSb10w5BnVo03pMKn2LFjJp83sLHplgq6hXesFpem/RWipRfu7bv0jUOjIuR1w== X-Received: by 2002:a17:902:e54e:b0:1c9:ddd8:9950 with SMTP id n14-20020a170902e54e00b001c9ddd89950mr17532154plf.21.1698184208126; Tue, 24 Oct 2023 14:50:08 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id k20-20020a170902ba9400b001b891259eddsm7867560pls.197.2023.10.24.14.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:50:07 -0700 (PDT) Date: Tue, 24 Oct 2023 14:50:07 -0700 From: Kees Cook To: "Matthew Wilcox (Oracle)" Cc: Steven Rostedt , Christoph Hellwig , Justin Stitt , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Kent Overstreet , Petr Mladek , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Michael Ellerman Subject: Re: [PATCH] powerpc: Remove initialisation of readpos Message-ID: <202310241449.7E91697@keescook> References: <20231024145600.739451-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024145600.739451-1-willy@infradead.org> On Tue, Oct 24, 2023 at 03:55:59PM +0100, Matthew Wilcox (Oracle) wrote: > While powerpc doesn't use the seq_buf readpos, it did explicitly > initialise it for no good reason. > > Fixes: d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq") > Signed-off-by: Matthew Wilcox (Oracle) Yeah, looks right -- it'd even be right if the member still existed. :) Reviewed-by: Kees Cook -- Kees Cook