From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD836A34D for ; Thu, 14 Dec 2023 21:39:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NkoL1B81" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d3470496e2so28317905ad.1 for ; Thu, 14 Dec 2023 13:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702589951; x=1703194751; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e9p8Ajf3tFQXbwC42EgP/DdM/mZur4gEPrUVHC58JLk=; b=NkoL1B812AhnfwtL7DSfU4lFuIy9AvKrpEdo6WxTSeg70wXMdYo8BejFrKl5mwkgXr CoiaMKY+91+hQBQyj19hRCpw2NaLwL/4xycLOBTwuGjCYMFU95FjKBj0PipVAPmdXH+T Uv/E9iRxMGgBGOLQFvu5z35z4cc2d6jk0FHOg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702589951; x=1703194751; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e9p8Ajf3tFQXbwC42EgP/DdM/mZur4gEPrUVHC58JLk=; b=rzO7Jj6iwQdfy1jglDHjUW7IySv1DFb3Ardx5C5zA0OId7GQ7YeV2vUPeut6DYr4JA jsvTmkqWHYlo8p7g04cRrKbPvSaCW3mvc89RqIoRN2aoFFiHhbyejsMqhfBxkoK13d0D PFZcDB6BiJqK/g49LspHYUgi3uHlwTj1AZjGsmnMWMv6u76ikxCxLyso0L0lDSCP8xsj sEHZuPybDeIvbagt2e4XiVtlg9g2gem3V3k79EpeG2sSfm1eOcfPFhFudMkmcFd1yeUr 7T7SweoKn/bmJWO8Q6w0kGWDuyCbwTswYlQFZD+NbD1KgTm4Pg/cPKE75PiNWvJaDOFR W5Cg== X-Gm-Message-State: AOJu0YwrKW7oskYY+5kq7SQ5csWC4feMV27S6pIJ3FoYrho+QrOKBhVv g21pu1ebotgvSz+M1B9f1Qg/cg== X-Google-Smtp-Source: AGHT+IEU6ftrI0VMvvVDF5jJLD9KtjtMPRzjUvkB4CgdFRkuRurVj+l8UJlY1TjY65o9czmfNcLAvQ== X-Received: by 2002:a17:902:ecc4:b0:1d3:6b17:67c0 with SMTP id a4-20020a170902ecc400b001d36b1767c0mr1775536plh.75.1702589950824; Thu, 14 Dec 2023 13:39:10 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id g16-20020a1709029f9000b001d3561680aasm3191596plq.82.2023.12.14.13.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 13:39:10 -0800 (PST) Date: Thu, 14 Dec 2023 13:39:09 -0800 From: Kees Cook To: tanzirh@google.com Cc: Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , Andrew Morton , llvm@lists.linux.dev Subject: Re: [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU Message-ID: <202312141338.CAA7708BC4@keescook> References: <20231214-libstringheader-v2-0-0f195dcff204@google.com> <20231214-libstringheader-v2-2-0f195dcff204@google.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214-libstringheader-v2-2-0f195dcff204@google.com> On Thu, Dec 14, 2023 at 09:06:13PM +0000, tanzirh@google.com wrote: > This diff uses an open source tool include-what-you-use (IWYU) to modify > the include list changing indirect includes to direct includes. > IWYU is implemented using the IWYUScripts github repository which is a tool that is > currently undergoing development. These changes seek to improve build times. > > This change to lib/string.c resulted in a preprocessed size of > lib/string.i from 26371 lines to 5259 lines (-80%) for the x86 > defconfig. > > Link: https://github.com/ClangBuiltLinux/IWYUScripts > nit: Please drop this blank line to keep your tags together. > Signed-off-by: Tanzir Hasan I'm glad to see such a big difference with just a little header tweaking. I look forward to more like this! Reviewed-by: Kees Cook -- Kees Cook