From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 514DD38DF4 for ; Tue, 23 Jan 2024 21:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706045474; cv=none; b=qtWnE+8kpGym5bpu47L8/M95ntYStE3yY3JD/JJf0hJ5fVywgCz3jQarnlN0744nfUjRMC31sRnnT5eboSGMc0sX2aEdTP7VKmWCFxWoX0+O+iTl4+Uw70ERwNm7WFIcH6hSc4t3XCUBXbqc+QOMLxGiXrNAu5Dl4buchvZatz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706045474; c=relaxed/simple; bh=jP2/IW9UNkEjSgAKZeY0ax+X34XlCZzhZYmXu4icG+o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bt5u7gyag6PhZ4Q1trldtWqLo2iFa2ZV79Rf8flpGWtg0Xz9YmeZ4xSV8qY6d1HBzPwSeWeXCKBOtnS7ol+HZzy3jkEYS4XS2LnGFoVJ44/WJkTYQpQJrGELoW5KcAso7QvHCMobBhhFCr4LsKCKdCcY95h8hjS9Li3UBqUt3d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ad60CBuj; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ad60CBuj" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5d42e7ab8a9so465945a12.3 for ; Tue, 23 Jan 2024 13:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706045472; x=1706650272; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cLSrHTqApY0rnoNDPNmTbGyM4UlT798vTtkhFOVuGO8=; b=Ad60CBujlqu06M2IFBbPXvjYD8g/BEXRejYj+DNvOwe8wY8n5vBoew7hrTl/u+VcTX Mw1Suq5x7dhwT8+Kg1UpTRVofpgjJnrHYr6gl+HBY//ZZHbqrNqMWfVbigTZJZHXagmU rnCo70Rr5QxK6vUJfK1EJi4krFDpBRl+2UwKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706045472; x=1706650272; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cLSrHTqApY0rnoNDPNmTbGyM4UlT798vTtkhFOVuGO8=; b=Ft8a+yFYuv03WCt/ktqVaEYbwVAAMrtdse9mrdf/+eqXhEmfwEyGkYAvTuhZ450l4D 9ZkMVTxNNkGTuc9e1UE27b706AgsElLga3AP1hZijZMfN2IwtPpjrLQAhQu5rtpp6A/W +wQoPanfEzm0DxtpR/P9K23P4lOgAga4e7MqypPUlUTxKcJ8R+jKK5XHzTS+sK70JLAF sxke1bHuh6GhyqeHzMql2RbUKytxlAtf2yiZTmIltg74A8hUrPaehntVo+aM43MKU3fQ LJazNQbz/4qzdIJpP4c5RZLFixdQE3m5kwoyF8K7j4Fz9l+EV/l/QQbQWuOwrb1zm4t4 KIPw== X-Gm-Message-State: AOJu0YxOOhwvM3Z6vYkIROxFe0Lin8kwsgUBN200WhBfEu5NLSruiywk rdOFQvPSUlkVsPNYv/NM7gH2VCYMUXLJr0w90ixR+8PAU70ku07lo2rlULDxxA== X-Google-Smtp-Source: AGHT+IFZZEebKX2R0JqbRWEEh9em7MQ0hN72r+XKI76xsV+huWAf7uMifAtdFdhTI+U9kp5jq78zPg== X-Received: by 2002:a05:6a20:28a1:b0:19a:3a7f:63cd with SMTP id q33-20020a056a2028a100b0019a3a7f63cdmr3098127pzf.49.1706045472672; Tue, 23 Jan 2024 13:31:12 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id kr8-20020a056a004b4800b006da73b90fe4sm12541675pfb.14.2024.01.23.13.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 13:31:12 -0800 (PST) Date: Tue, 23 Jan 2024 13:31:11 -0800 From: Kees Cook To: Adrian Hunter Cc: linux-hardening@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Fangrui Song , linux-perf-users@vger.kernel.org, "Gustavo A. R. Silva" , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 69/82] perf tools: Refactor intentional wrap-around test Message-ID: <202401231330.C55D17922@keescook> References: <20240122235208.work.748-kees@kernel.org> <20240123002814.1396804-69-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 23, 2024 at 08:21:41AM +0200, Adrian Hunter wrote: > perf tools has separate includes to the kernel, so does not > seem to include add_would_overflow() in any of its include > files at this point. Need to update > tools/include/linux/overflow.h first. Oops, thank you! I will adjust this. -- Kees Cook