From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 260FE64D for ; Sat, 24 Feb 2024 00:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708734470; cv=none; b=FhH013kB0afDClb72cgmeYJTU98s+pQh/Jr2xmx3RA1i4q4vf+SSkOtNWkoJyrRoogZ4QRkgPNf7/00WpFEfvq3GHHnr86lo7z9p9+LiyYrB2jo5in0xA8tqeS97LtR1fR5RjQuEg2QzXST0VVQyfblht6EwMEYCR23GI00Wdow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708734470; c=relaxed/simple; bh=rgLsaSsKqhDN11XXsl7SBz4QYb2l1KqGudDgv2mpG/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=otPeFsNHsNUIu+xs2/NIhFMY+/B+THMwbmyvb0J74iMFXh4ZFzjV8dtHSSfiTTa54c2bq6ypRahfBFy+38n49pDlSyglKCPC2J7xgB4uzevj+Jf5CnufAoaKFegRlG2sl44tafi+9NRu+ENxdZ0tgGibwuHOPp1Xi2YaiY7+yjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ehFNujYN; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ehFNujYN" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e47a104c2eso979690b3a.2 for ; Fri, 23 Feb 2024 16:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708734468; x=1709339268; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jX3JXs6F7q/8BnIOexrzyzqfCwNhMyVCMGgfEA4FEVs=; b=ehFNujYNUw3vhiNrJtlQMyBFPNIHICaRgZdOV1wntnBywWgca0H/TZouUgBS3ckXpq Sj1HGsAQ1PdUgzyzgsZ+mCWP52fSxnjYDAQQf2a0/F1XRd7J64HdLFetNXg63fK0PXQt m8FrqMWptR0pAN/sn0PURDEYG7BuC0snf7Cqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708734468; x=1709339268; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jX3JXs6F7q/8BnIOexrzyzqfCwNhMyVCMGgfEA4FEVs=; b=jjt551ZWqQTyG7AXNAI9L6ieBRb5hJWlBHIJK/fqjjp/O56f4nBSOOYK4IGwanC2Gm FAk0tXJLlUUN5SH+nw750GBx1ESHZ8q1e5PkrAeBM5zEGEG1WidXQyHFsndjb14Nx54H RpeyauPnF2/cG/pucLLpwaFL6uEeAzoUISl/F916ZwiOfuX9tjpTWrl9U2svRH6a8hcH NtrxNNBiLgCYuKXiOLonubOS/I1zKI754OB8/32OB/x01WC1cLG5JDn9EicG+3zXCJ0Q WPGDQxXtSm46AQSt1idMP5G6rF84/R9g1agwboqN115tPxxuN+saOwPWPGdp8AfEbBy9 xQeA== X-Forwarded-Encrypted: i=1; AJvYcCX+CG3Yy6sl4UU7/cvj6E+36lzZqrMVxm3kvsk0msanw2J7M8dhSC/RMUnITtk/0BJwwyYwdwke1Y2TC7TgNWCUpoDtfBL7OLCmMxWx3GL8 X-Gm-Message-State: AOJu0Yw9oR2dqK4opV/VM/oscAqjb2P55CBYOK2A3E5rKXTRgdGJ9iN+ HekGNlhlp/+liKk8FEYgDWK83eA3Kfz3mMpj4JWmJA4VJqP3oi8FIjcLs/8LNg== X-Google-Smtp-Source: AGHT+IETT3HwnaAs3jTQFeXYPTU7J+2asNMwkklPlBU3DazlDcRsrwOBcFqTj0a/gtB9u0fJzAsU6A== X-Received: by 2002:a05:6a20:8f95:b0:1a0:566a:5974 with SMTP id k21-20020a056a208f9500b001a0566a5974mr1427284pzj.61.1708734468509; Fri, 23 Feb 2024 16:27:48 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id lp16-20020a056a003d5000b006e4c7aa0ba4sm58482pfb.182.2024.02.23.16.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 16:27:48 -0800 (PST) Date: Fri, 23 Feb 2024 16:27:47 -0800 From: Kees Cook To: Justin Stitt Cc: Sathya Prakash Veerichetty , Kashyap Desai , Sumit Saxena , Sreekanth Reddy , "James E.J. Bottomley" , "Martin K. Petersen" , Suganath Prabu Subramani , Ariel Elior , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, Nilesh Javali , Manish Rangankar , Don Brace , mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, netdev@vger.kernel.org, storagedev@microchip.com Subject: Re: [PATCH 6/7] scsi: smartpqi: replace deprecated strncpy with strscpy Message-ID: <202402231627.13E27D4@keescook> References: <20240223-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v1-0-9cd3882f0700@google.com> <20240223-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v1-6-9cd3882f0700@google.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v1-6-9cd3882f0700@google.com> On Fri, Feb 23, 2024 at 10:23:11PM +0000, Justin Stitt wrote: > buffer->driver_version is sized 32: > | struct bmic_host_wellness_driver_version { > | ... > | char driver_version[32]; > ... the source string "Linux " + DRIVER_VERISON is sized at 16. There's > really no bug in the existing code since the buffers are sized > appropriately with great care taken to manually NUL-terminate the > destination buffer. Nonetheless, let's make the swap over to strscpy() > for robustness' (and readability's) sake. > > Signed-off-by: Justin Stitt Yup, good cleanup. Reviewed-by: Kees Cook -- Kees Cook