From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 070357C0A8 for ; Mon, 4 Mar 2024 23:03:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709593400; cv=none; b=u+MGE+Oedt9v/FwPxvGMFZ6EQNPiIkNG7xNoM5vchG4SiB03TsD1a8wMgtf4I1gkZzsmXLdUOBQyug9vPBjwPdZL85eegkz5cVaJyyniD/9AVUJL3j9dV5Bljtfsgc1DGPNlTVHPpr3a0JPl9VebSwrSi/uos3wX9bPLu4rPHEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709593400; c=relaxed/simple; bh=7WegmzHOMCbx4tuQ23wzNZFpsXhn+SpD9Xu3BPE9yV8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o+XrRWgx++O3qB6JhMMifDe2/sJk8EUPMnK9xAiTIINa6J1uaRmla8LvcfpYRMCZusmJnoobSqH96ed10jlz+43HGv1aGk7wJ1RXv4ZR5MRgi4HDXYFfdI590ouBrvKw0q+4jntirYa8892Q7kzn5uMHJ6Yju+ueh2L2JH4NY0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MWIfQ8je; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MWIfQ8je" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dc418fa351so44280125ad.1 for ; Mon, 04 Mar 2024 15:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709593398; x=1710198198; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zra570GFR/pjaJOF7w0ZjlWxu8eCrPVL1ueeZxNYpzs=; b=MWIfQ8jeMC8v6Z+60GpM2H7Sd92e+wbzvNan9EPrvt6nuj9ttlOqjdkrhRrYgqviub 0J68qEpVmXIjkZPMnc6ZWrjhWRhunw6/f9R0tf+fXdAfJhkshVhFgUirISaRCr/51qWy r99Hrza97tr+JBQFmxZgp4xAZ1gblbDL5pXdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709593398; x=1710198198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zra570GFR/pjaJOF7w0ZjlWxu8eCrPVL1ueeZxNYpzs=; b=LtNIUIOlRZkjsZcttTeBcGYH79Tr/NSyzNAnGNeLpqm50zPEE2KPSKfBNB51ZhUQsS i3srgXaPy/yEX5tVWmEFF80FKzOo4YUNnRLJvjPowdE41o5JIIjavIWg9bR2IgJDKxEI F4kTae9sR3L7SvQRuFI5wAfRzkZ+NgoSuATLg4d+moTl3uEFPkURDdNMnHg5POKlqU9p 1AXDhD/IdP8AxqIDjnfMsazYOgdIKDi4St5rncTlxxo/2HJ6yoTNTsPvXGgINYjbpinZ DQLxEgY9JAj5su/7w9ynpop03Vuhp0nQQ5Bjir0d4aIhIsldtGW93Mi1g8Y0hghMxzeg NIGA== X-Forwarded-Encrypted: i=1; AJvYcCVFLyLF6yuqfEJGvmdsyg8BUAxMPB+5Hc6uljP5TGuM9TMgxrxv5jMz6BPnPoTqIj/5sITECxlWq2OAUqS1BSvwB9i1JI3dOpDWywS4nw2O X-Gm-Message-State: AOJu0YzU/8JKKwaktrN1N05gkSQLTbM77A8qZFSmbJuwDhhrr+7u3Tdv iQtgtcSBTdutc7GhXWTz++v45EAQy4C+oIVsGgpL1DiyQ3Q+FI6iO5n9VQWNnw== X-Google-Smtp-Source: AGHT+IHsjDW+/7Ivd2i5nhU9uSJtEYy1nZXqKX/92Fray8kBkmWVSPGumJAavlMlS3tPeIDd5jdokQ== X-Received: by 2002:a17:902:ec8f:b0:1dc:fc84:198 with SMTP id x15-20020a170902ec8f00b001dcfc840198mr231857plg.29.1709593398024; Mon, 04 Mar 2024 15:03:18 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id o12-20020a170902d4cc00b001dc9422891esm9060623plg.30.2024.03.04.15.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 15:03:17 -0800 (PST) Date: Mon, 4 Mar 2024 15:03:16 -0800 From: Kees Cook To: Eric Biggers Cc: Vlastimil Babka , Christian Brauner , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr() Message-ID: <202403041502.28477148C0@keescook> References: <20240304184252.work.496-kees@kernel.org> <20240304184933.3672759-3-keescook@chromium.org> <20240304221648.GA17145@sol.localdomain> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304221648.GA17145@sol.localdomain> On Mon, Mar 04, 2024 at 02:16:48PM -0800, Eric Biggers wrote: > On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote: > > xattr: Use dedicated slab buckets for setxattr() > > This patch actually changes listxattr(), not setxattr(). > > getxattr(), setxattr(), and listxattr() all allocate a user controlled size. > Perhaps you meant to change all three? What is special about listxattr() (or > setxattr() if you actually meant to change that one)? Whoops. Yes, I did one and stopped. :P I'll fix it up in v2. -- Kees Cook