From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667B75F859 for ; Mon, 18 Mar 2024 23:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710805795; cv=none; b=qaPF82dpWoqx2Mf02OcMWT7//3n4mNdeRO5uLrVDeuBb44PMprX2JNK+kxYcXWDu2LVIQov30TUAygmuT5fQfR40k9aaMfaurbCkuOanFo2CWM7uQdCjhP+sySJltZIX08ODP1v6V4o9Rme1pCk3XBqvi9rnjcLMzkaHXa5vSvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710805795; c=relaxed/simple; bh=++8AIV7HG9payGSZCdI/YJMOMZaQDxTnyhPn9woYAqs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IYf6BaW0NAkJ5VivFv6GOSrcZXzmETyXgvHx4C36yWWX9uy2/a9GrPs8aEfRn5i/ptWjpsDv8E4OsjawQmbfwaOqgvge39WvmiFsUqHlO5+EJMXa+qykDac9PDWr/zSZ1edSyzQg3M3S535F9C3bE43sQPcideBXSWNhnQ5d9zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ji56pQvZ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ji56pQvZ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1def59b537cso22143895ad.2 for ; Mon, 18 Mar 2024 16:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710805794; x=1711410594; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vRkn/Ffa0kshb8/M23HImClN08sGjJ63GvS/V4Rk06I=; b=Ji56pQvZ6h5OLs7A0WB7yG6lpmLOpokga+eqJ3c0hKX/ZqYE52I00W7mz9On+kHujD JCm3PMUN221eD3/7vixTYaK1WLLzWWMQ7mhRL4RETfbR5LchPzRZCosc231qtTiYLcRA ofajvl6qH54rt0bj1TLrk3vRsRwFM3qXtaCfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710805794; x=1711410594; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vRkn/Ffa0kshb8/M23HImClN08sGjJ63GvS/V4Rk06I=; b=UrKpdPakGi1oZgevrpMPoex9tNzcEF0cBk86Z3iNAlpw+RXx/9TtrgMwpz172L8L12 djTAhSl7e8ku5KrrbEMSmyCV2ALnt3YeYrcStYvJ1c2UBMTr0P+Wr9L8Mp2zXLBm5Hl8 KYZLdP+PXTD1dwthOMDHeZ8MgGDeyOsvREFuvtiA5GjyI08TgN6Y2TnRqrSsGh8GKrnc Ofd1s70iGInEzvX1aHJKHoK4ZgNtIroFlPOntcAQ+Oym4baRiDyqfGaQ88UIAriZXISk +voZhZPtUG7Z+hVMMI8BMivZgqg95ldhVX6KntujU0vn1WW+9JYEmd1ME0LBO8DHRzEk jMlQ== X-Forwarded-Encrypted: i=1; AJvYcCUh381aweT3CAMTHhkhaAlnO6+OIOHYQcZVCRvTQBvFwPYP4tyN5LS0kj+/V2zXKpMkW5ZxSiz2TCB+QSooN12Fl2sphewcrwalvBd+mZYc X-Gm-Message-State: AOJu0YxEniXpvAsXX4dev08N/A+dKFj2UItvMvkWgUtfqNLH4/1IX0j8 KavmGusR3fffmAMazHuofnz8P2HQwiZQ3aXESeyKzt/LU5DxumXdwqFswrsijH1AwPSyJgtuqII = X-Google-Smtp-Source: AGHT+IHuA2onb1wnKM9PYOhYyVkXUleXOMB2F2xCC/G7R18UXwREYPkQdg9dME1Kl1WX8TGqOzk0Hg== X-Received: by 2002:a17:903:2448:b0:1e0:766:abe4 with SMTP id l8-20020a170903244800b001e00766abe4mr7899286pls.46.1710805793852; Mon, 18 Mar 2024 16:49:53 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id k5-20020a170902c40500b001dd635551f1sm9921941plk.255.2024.03.18.16.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 16:49:53 -0700 (PDT) Date: Mon, 18 Mar 2024 16:49:52 -0700 From: Kees Cook To: Justin Stitt Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] soc: qcom: cmd-db: replace deprecated strncpy with memcpy Message-ID: <202403181646.667970F76@keescook> References: <20240314-strncpy-drivers-soc-qcom-cmd-db-c-v1-1-70f5d5e70732@google.com> <202403181443.F4021C9F63@keescook> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 18, 2024 at 03:47:38PM -0700, Justin Stitt wrote: > Gotcha, I was operating under the assumption that we needed to know > the size of id at compile time. Apparently __builtin_object_size(_, 1) > will return SIZE_T_MAX if we don't know the size of something. Sending > a v2. Yeah, it only requires to know the compile-time size of the destination buffer. -- Kees Cook