From: Kees Cook <keescook@chromium.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux-hardening@vger.kernel.org
Subject: Re: __fortify_panic() question
Date: Wed, 29 May 2024 10:18:42 -0700 [thread overview]
Message-ID: <202405291018.F0B37DC6B@keescook> (raw)
In-Reply-To: <1c79d692-bd2c-4125-8a47-7593b3229379@quicinc.com>
On Wed, May 29, 2024 at 10:09:45AM -0700, Jeff Johnson wrote:
> On 5/29/2024 9:55 AM, Kees Cook wrote:
> > On Wed, May 29, 2024 at 07:36:25AM -0700, Jeff Johnson wrote:
> >> 'make W=1 C=1' on x86 gives the warning:
> >> arch/x86/boot/compressed/misc.c:535:6: warning: symbol '__fortify_panic' was not declared. Should it be static?
> >
> > Hm, I can't reproduce this currently (but yes, it looks like arm vs x86
> > is mismatched). What tree is this?
>
> e0cce98fe279 (linus/master, linux-master) Merge tag 'tpmdd-next-6.10-rc2' of
> git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd
>
> >
> >> Looking at this I see for ARM there is a prototype for __fortify_panic() in
> >> arch/arm/boot/compressed/misc.h
> >> And there is a matching implementation in arch/arm/boot/compressed/misc.c
> >>
> >> But for x86 there is only the implementation in
> >> arch/x86/boot/compressed/misc.c
> >> There is not a prototype in arch/x86/boot/compressed/misc.h.
> >>
> >> The easy fix for this would be to add a prototype to
> >> arch/x86/boot/compressed/misc.h.
> >
> > Yeah, I think this is the right solution.
>
> You want to do this, or should I?
Please feel free! I'd appreciate it. :)
--
Kees Cook
prev parent reply other threads:[~2024-05-29 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 14:36 __fortify_panic() question Jeff Johnson
2024-05-29 16:55 ` Kees Cook
2024-05-29 17:09 ` Jeff Johnson
2024-05-29 17:18 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405291018.F0B37DC6B@keescook \
--to=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox