From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6450206E6D; Tue, 29 Oct 2024 14:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730212933; cv=none; b=tKpNs1usl3GXQxJfS5jLJSG5sTlzlzRQgI5WjY2B9YmHTs91MJUjPx6zc2PMJmI3GcQeO8PEcRDxt/3WUhNwRJbUvxGGMTrGbP6vcOoccyJXqhgwOJZlU5KRb+2ZYotMF0jqHPQ80wkclwm4jb2IYOWVMGw7cXCsWAH7vC8cIHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730212933; c=relaxed/simple; bh=eb4/agc7lIp7xggxiMeKGEgevS+k7MTVTxFox6avOPg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sNikkMxFXHsCDRJTtqzqK+r68he4Z9Pju9S2q2aLTOb8/fotUlW9Vu2fPQ2whMVxxVB67Ara79jttJh3O+Cy1Vt//ezpEQkOk/o/FDeIVwkUODO5zal52EkMskJqeRKckRoine9ccUIA7IvyHQ0eyENb0QEXxOAhOxGOhErE6g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JaPA2jNP; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JaPA2jNP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730212931; x=1761748931; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eb4/agc7lIp7xggxiMeKGEgevS+k7MTVTxFox6avOPg=; b=JaPA2jNP57OeJEUSCuv0fZQJy6LHy0B0BuJOdO+1GKDL5w/fwUWv9QUE RO5Tp0HxhkxtieCbKwHu5pl6eUlpGRJtQovaEoO4wl/tPL7Bk+j3upkNY sbJtE2/qOl3ETdxhaLYbOLILqPI7M81rsw8BjlHYXwcmNK8o/O4/SqNkO fP6DLAahI8CT8PjOuhQhmg80/oB2b6WIKKaJdGVyldNfWVTsGYATBClmL J2FC+pDeCCxa71zyYTyNNw15eQUQrFJAidq0PRAQeIou6QF6rvhKv3yjm jaeCR3M/FWh2hGblvh9/Ovy3yaBVm4rin4M9tXFxin9yBMXBk2uhqRwbt g==; X-CSE-ConnectionGUID: QrmHR0V6Q4GpSaVoJZfMTg== X-CSE-MsgGUID: fkoN5ar8SyqeM0KqROdfQA== X-IronPort-AV: E=McAfee;i="6700,10204,11240"; a="33653764" X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="33653764" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 07:42:11 -0700 X-CSE-ConnectionGUID: 7F9LJjzHQE+8h7YADA97jA== X-CSE-MsgGUID: CvtmaoCmQDCpmSam6J0E5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="82794215" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 29 Oct 2024 07:42:05 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t5nQ3-000dmO-09; Tue, 29 Oct 2024 14:42:03 +0000 Date: Tue, 29 Oct 2024 22:41:50 +0800 From: kernel test robot To: Coiby Xu , kexec@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, Ondrej Kozina , Milan Broz , Thomas Staudt , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Kairui Song , Jan Pazdziora , Pingfan Liu , Baoquan He , Dave Young , linux-kernel@vger.kernel.org, x86@kernel.org, Dave Hansen , Vitaly Kuznetsov , Greg KH , Vivek Goyal , Eric Biederman , Kees Cook , "Gustavo A. R. Silva" , "(open list:KERNEL HARDENING (not covered by other areas):Keyword:b__counted_byb)" Subject: Re: [PATCH v6 3/7] crash_dump: store dm crypt keys in kdump reserved memory Message-ID: <202410292237.HA9vMqbC-lkp@intel.com> References: <20241029055223.210039-4-coxu@redhat.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241029055223.210039-4-coxu@redhat.com> Hi Coiby, kernel test robot noticed the following build errors: [auto build test ERROR on e42b1a9a2557aa94fee47f078633677198386a52] url: https://github.com/intel-lab-lkp/linux/commits/Coiby-Xu/kexec_file-allow-to-place-kexec_buf-randomly/20241029-135449 base: e42b1a9a2557aa94fee47f078633677198386a52 patch link: https://lore.kernel.org/r/20241029055223.210039-4-coxu%40redhat.com patch subject: [PATCH v6 3/7] crash_dump: store dm crypt keys in kdump reserved memory config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241029/202410292237.HA9vMqbC-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241029/202410292237.HA9vMqbC-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410292237.HA9vMqbC-lkp@intel.com/ All error/warnings (new ones prefixed by >>): kernel/crash_dump_dm_crypt.c: In function 'crash_load_dm_crypt_keys': >> kernel/crash_dump_dm_crypt.c:221:16: error: variable 'kbuf' has initializer but incomplete type 221 | struct kexec_buf kbuf = { | ^~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:222:18: error: 'struct kexec_buf' has no member named 'image' 222 | .image = image, | ^~~~~ >> kernel/crash_dump_dm_crypt.c:222:26: warning: excess elements in struct initializer 222 | .image = image, | ^~~~~ kernel/crash_dump_dm_crypt.c:222:26: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:223:18: error: 'struct kexec_buf' has no member named 'buf_min' 223 | .buf_min = 0, | ^~~~~~~ kernel/crash_dump_dm_crypt.c:223:28: warning: excess elements in struct initializer 223 | .buf_min = 0, | ^ kernel/crash_dump_dm_crypt.c:223:28: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:224:18: error: 'struct kexec_buf' has no member named 'buf_max' 224 | .buf_max = ULONG_MAX, | ^~~~~~~ In file included from include/linux/limits.h:7, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/loongarch/include/generated/asm/preempt.h:1, from include/linux/preempt.h:79, from include/linux/rcupdate.h:27, from include/linux/rbtree.h:24, from include/linux/key.h:15, from kernel/crash_dump_dm_crypt.c:2: >> include/vdso/limits.h:13:25: warning: excess elements in struct initializer 13 | #define ULONG_MAX (~0UL) | ^ kernel/crash_dump_dm_crypt.c:224:28: note: in expansion of macro 'ULONG_MAX' 224 | .buf_max = ULONG_MAX, | ^~~~~~~~~ include/vdso/limits.h:13:25: note: (near initialization for 'kbuf') 13 | #define ULONG_MAX (~0UL) | ^ kernel/crash_dump_dm_crypt.c:224:28: note: in expansion of macro 'ULONG_MAX' 224 | .buf_max = ULONG_MAX, | ^~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:225:18: error: 'struct kexec_buf' has no member named 'top_down' 225 | .top_down = false, | ^~~~~~~~ kernel/crash_dump_dm_crypt.c:225:29: warning: excess elements in struct initializer 225 | .top_down = false, | ^~~~~ kernel/crash_dump_dm_crypt.c:225:29: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:226:18: error: 'struct kexec_buf' has no member named 'random' 226 | .random = true, | ^~~~~~ kernel/crash_dump_dm_crypt.c:226:27: warning: excess elements in struct initializer 226 | .random = true, | ^~~~ kernel/crash_dump_dm_crypt.c:226:27: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:221:26: error: storage size of 'kbuf' isn't known 221 | struct kexec_buf kbuf = { | ^~~~ >> kernel/crash_dump_dm_crypt.c:246:20: error: 'KEXEC_BUF_MEM_UNKNOWN' undeclared (first use in this function) 246 | kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; | ^~~~~~~~~~~~~~~~~~~~~ kernel/crash_dump_dm_crypt.c:246:20: note: each undeclared identifier is reported only once for each function it appears in >> kernel/crash_dump_dm_crypt.c:247:13: error: implicit declaration of function 'kexec_add_buffer' [-Wimplicit-function-declaration] 247 | r = kexec_add_buffer(&kbuf); | ^~~~~~~~~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:221:26: warning: unused variable 'kbuf' [-Wunused-variable] 221 | struct kexec_buf kbuf = { | ^~~~ vim +/kbuf +221 kernel/crash_dump_dm_crypt.c 218 219 int crash_load_dm_crypt_keys(struct kimage *image) 220 { > 221 struct kexec_buf kbuf = { > 222 .image = image, > 223 .buf_min = 0, > 224 .buf_max = ULONG_MAX, > 225 .top_down = false, > 226 .random = true, 227 }; 228 int r; 229 230 231 if (key_count <= 0) { 232 kexec_dprintk("No dm-crypt keys\n"); 233 return -EINVAL; 234 } 235 236 image->dm_crypt_keys_addr = 0; 237 r = build_keys_header(); 238 if (r) 239 return r; 240 241 kbuf.buffer = keys_header; 242 kbuf.bufsz = get_keys_header_size(key_count); 243 244 kbuf.memsz = kbuf.bufsz; 245 kbuf.buf_align = ELF_CORE_HEADER_ALIGN; > 246 kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; > 247 r = kexec_add_buffer(&kbuf); 248 if (r) { 249 kvfree((void *)kbuf.buffer); 250 return r; 251 } 252 image->dm_crypt_keys_addr = kbuf.mem; 253 image->dm_crypt_keys_sz = kbuf.bufsz; 254 kexec_dprintk( 255 "Loaded dm crypt keys to kexec_buffer bufsz=0x%lx memsz=0x%lx\n", 256 kbuf.bufsz, kbuf.bufsz); 257 258 return r; 259 } 260 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki