From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246031FAC5C for ; Tue, 14 Jan 2025 18:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736879366; cv=none; b=ISUiGvmPoX9uexruLJSfG/LPsK/T8MiUfJwNOw6kNlCiwfLKpZ3r5xt0SYxS43n3jjeTA4NDQy/br5an/QyNlozsppY7Xgjk4AKzQAc1/T2bglg6bzZVrJ8RkqMEFCGN7kDggwj+AEwhIkNkE/dzFh3+zmFV8VL+b04NNmxUMVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736879366; c=relaxed/simple; bh=jsa0CovMO5ZT70pqhIrCF6Xwrs9x8fVebY2Xd/EYn6o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pC+CE74wdJ2y+qagm1KqvArcQjzmZjf8DdoQ6ZqqxuEJsW8Dz5A1b6N8fDVn6TDyYEO5CxrML8ejzmouclkvbTEQNvH5I96B+g9ryr//xx8cWJyBG8t8N1LvF/QH3ehQsuSM2qSug2hAHjrryyoy6jjtSU7QwNTa1f3vqcUs+vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=KFBFTQuv; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="KFBFTQuv" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d3bdccba49so9848505a12.1 for ; Tue, 14 Jan 2025 10:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1736879362; x=1737484162; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+L6x2g4BC/d/+jfoDGOj0pMskOpzz9VGXCLG5E4WwRY=; b=KFBFTQuv4suEhQgFHTC00K5qiQ3Jw2kiLcP2Ut9JBRBrS6MG3+DcQWnTJ2OvOmD2ET VmAoHdL2GNwADncv1A6R63Igi6HrsrO4q0Iy0Tf0ktWX9MhkhZAWTt4DFpf39SgVrvcn goB1HrkuDsZ6EUUMHyn+nRAXkfPC0D6r+s8all1P1Tni6YRXh8p/Hn56TaO13lf8p0o+ e8waI5tHtQROzxqeDrKmwdFRhQ/JWlNMRBEbvpsdANDX4sa5h9naV2GPaEWOaWIvEYUT GOIozzsliRXxnLRPkM//8kc56luukRtxY3CL4EKdxIA1Jd9xtXGcUDyU6uX7Lky9U82N XglQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736879362; x=1737484162; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+L6x2g4BC/d/+jfoDGOj0pMskOpzz9VGXCLG5E4WwRY=; b=XPPl8d0toVtuM1PFjWkFywCUreVvfhDTLMbUTF7WB8viwtvzH1QjTl80D2Q8yrSTsc VmphV3tSZiiB+3WjnAPs4hoKrzlvEkeVoHWcHQNMYH+feP4vURnohXPjbcbEVk1UsLS9 Q1Td9/1y7V0jo6gPgSLrJgIVgGz5gJhPbias6nCEmv1XED3I+J+diEh4tMcS2mW5qOIu 3I0XbEqhwyNZmHSZ3+wlaSyn0ArEC6Rwh4+KvkTWhkpYFSeXywvJXs5qq5mH1A48ZFcX uw4e/zgYDPmy/vJeFOBP2/lcr22Ajsck4KAOVgU+7ti4MO3AkKGUrh8x9XCGi+4PST2o Uzyg== X-Forwarded-Encrypted: i=1; AJvYcCU5qy7a+FvZMOlK27G6jgaGPx6BIwOHQ2nzbk1jI6CXeQVUciR1Jlwz/UEu2zbtSUHpZXC5ToEybHiFAYLmERw=@vger.kernel.org X-Gm-Message-State: AOJu0YwOwfQx6VIZIyfX5bR+TF062s2lDaXGQ2gfitqTQUTSTrNq3F3x Iy+txuHa2+/7llRlk3U7X+SXGp+kZpHmH22NaQt1hUDydSg3+UQNTjr3QJttEYs= X-Gm-Gg: ASbGncssRAVmm33SxqMLah4jcPZkWZB4hZcdiqelKJGFMhq2m0H7jQzsO2RZQ+Hsl2u /uCJ2HxygolU3cK62WkeAXbtpX2YJH/4YhlWMiaat0TdQJTv6Qux6CbIU8X4es+VBkLaT+awtPP TIClR5KwYfVXYlE/ixYHI7I2r8UWr+nlB++o9elmpdkmpyLAEO+tXKiO5lswtf26p6/4EgxA40C rLum+i8708EBYjkjklXtORVjNbOKvuXZUMR8XpsobmC3tzvJaSHyRk8GGuCPQMcNddA6fBgn9Nu mN8x1YDAWEDENEci63puLcLBGt6YGx0P3hk1FMSlew== X-Google-Smtp-Source: AGHT+IElLRyBSSFsvDLttv+1rxbirlHss1/zCBNTWvitDc/Y1ed9oUs4kNSXL7wHp3+sai4oSrFAlg== X-Received: by 2002:a17:907:96a7:b0:aa6:2c18:aaa2 with SMTP id a640c23a62f3a-ab2ab73e7dbmr2340049566b.27.1736879362392; Tue, 14 Jan 2025 10:29:22 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c905f04fsm659166066b.27.2025.01.14.10.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 10:29:21 -0800 (PST) Date: Tue, 14 Jan 2025 19:29:21 +0100 From: Andrew Jones To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: Re: [PATCH v4 10/30] riscv/paravirt: Mark pv_steal_clock static call as __ro_after_init Message-ID: <20250114-7fc0ed577ee91b6813f92806@orel> References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-11-vschneid@redhat.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250114175143.81438-11-vschneid@redhat.com> On Tue, Jan 14, 2025 at 06:51:23PM +0100, Valentin Schneider wrote: > The static call is only ever updated in: > > __init pv_time_init() > __init xen_time_setup_guest() > > so mark it appropriately as __ro_after_init. > > Signed-off-by: Valentin Schneider > --- > arch/riscv/kernel/paravirt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/paravirt.c b/arch/riscv/kernel/paravirt.c > index fa6b0339a65de..dfe8808016fd8 100644 > --- a/arch/riscv/kernel/paravirt.c > +++ b/arch/riscv/kernel/paravirt.c > @@ -30,7 +30,7 @@ static u64 native_steal_clock(int cpu) > return 0; > } > > -DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); > +DEFINE_STATIC_CALL_RO(pv_steal_clock, native_steal_clock); > > static bool steal_acc = true; > static int __init parse_no_stealacc(char *arg) > -- > 2.43.0 > Reviewed-by: Andrew Jones