From: Steven Rostedt <rostedt@goodmis.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/synthetic: Replace deprecated strncpy() with strscpy()
Date: Tue, 11 Mar 2025 08:37:01 -0400 [thread overview]
Message-ID: <20250311083701.6947bd0d@batman.local.home> (raw)
In-Reply-To: <20250310200359.450172-1-thorsten.blum@linux.dev>
On Mon, 10 Mar 2025 21:03:58 +0100
Thorsten Blum <thorsten.blum@linux.dev> wrote:
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index e3f7d09e5512..4b51f74897b4 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -207,8 +207,7 @@ static int synth_field_string_size(char *type)
> if (len == 0)
> return 0; /* variable-length string */
>
> - strncpy(buf, start, len);
> - buf[len] = '\0';
> + strscpy(buf, start, len + 1);
>
> err = kstrtouint(buf, 0, &size);
> if (err)
> -
Looking at the code, it calculates the start and end by scanning the
string. I think it's better to just use memcpy() instead. It's not like
it's copying a random string passed in.
-- Steve
prev parent reply other threads:[~2025-03-11 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 20:03 [PATCH] tracing/synthetic: Replace deprecated strncpy() with strscpy() Thorsten Blum
2025-03-11 12:37 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311083701.6947bd0d@batman.local.home \
--to=rostedt@goodmis.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox