Linux Hardening
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] regulator: hi6421v600: Truncate long strings for trailing NUL
Date: Mon, 7 Apr 2025 11:35:33 -0700	[thread overview]
Message-ID: <202504071134.1AAF30CAF5@keescook> (raw)
In-Reply-To: <20250310222408.work.339-kees@kernel.org>

On Mon, Mar 10, 2025 at 03:24:09PM -0700, Kees Cook wrote:
> GCC 15's -Wunterminated-string-initialization saw that these strings
> were being truncated. Adjust the initializer so that the needed final
> NUL character will be present.
> 
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Kees Cook <kees@kernel.org>
> ---
>  drivers/regulator/hi6421v600-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/hi6421v600-regulator.c b/drivers/regulator/hi6421v600-regulator.c
> index e5f6fbfc9016..e74f992fd85f 100644
> --- a/drivers/regulator/hi6421v600-regulator.c
> +++ b/drivers/regulator/hi6421v600-regulator.c
> @@ -275,7 +275,7 @@ static int hi6421_spmi_regulator_probe(struct platform_device *pdev)
>  }
>  
>  static const struct platform_device_id hi6421_spmi_regulator_table[] = {
> -	{ .name = "hi6421v600-regulator" },
> +	{ .name = "hi6421v600-regulato" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(platform, hi6421_spmi_regulator_table);
> @@ -283,7 +283,7 @@ MODULE_DEVICE_TABLE(platform, hi6421_spmi_regulator_table);
>  static struct platform_driver hi6421_spmi_regulator_driver = {
>  	.id_table = hi6421_spmi_regulator_table,
>  	.driver = {
> -		.name = "hi6421v600-regulator",
> +		.name = "hi6421v600-regulato",
>  		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
>  	},
>  	.probe	= hi6421_spmi_regulator_probe,

Friendly ping on this patch. Who can pick this up?

Thanks!

-Kees

-- 
Kees Cook

  reply	other threads:[~2025-04-07 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 22:24 [PATCH] regulator: hi6421v600: Truncate long strings for trailing NUL Kees Cook
2025-04-07 18:35 ` Kees Cook [this message]
2025-04-07 18:48   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202504071134.1AAF30CAF5@keescook \
    --to=kees@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox