From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45F3926A0CF for ; Wed, 9 Apr 2025 14:43:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209823; cv=none; b=iEu/NtoN+zAfTIQLNVVyfW/b3S3e+uc2YAYgdbE/pA4ANxE4iknn39RrIq9VgJOm2xsX4X9HsfmlRTPDWZgnGYx3Ls/WzDrJsFEfn3LXeoyePaRjR4GRz09cEfFOZU6g5sWgr/rfWD3e0Nd2AGxfmvqTVncAG2tncLTeWiXi6mQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209823; c=relaxed/simple; bh=zcW7KAg7HhPKWhoaSkSMXeVXmh0E4wW5ONt/f7Ws2Vs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ftI3yttQTyVnQmJltUlo2UxhjhcGsVZFKicXqRFblKv4MdGe31QbGJYaqn121JCsB2cSTXvKIHXRXV5kQ5dQ3qoPknJBaAjQnxE08vvcJgAJvOQoEXzLU0AgfyEFI+0HdoxWT+xSsDR8dGUp+BiBjpLqtIvCiw2wD/GTE19P7W0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ddEeg35H; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddEeg35H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744209820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oCD+m2G43Hli8f9qfAuEmMjDrSbNT2k9Z1hxPSQ/17g=; b=ddEeg35H4UPhtJQf7sp9phc+zYAr1I6KaAc6PmHcbiI7Oujw7itzyzV/pRxsMO7w+9dzQy J13YnLHuIVJp2XU3qUJg5HYOfypYEdFWt+UzEhnhf91elQ16qbxJKonkUzhmJAaQQaxU6Q wG/wfqR5TLWx2w6ztfL0kcYM5I09Cxw= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-30uz0RfMNzC9PgkhK8RUUA-1; Wed, 09 Apr 2025 10:43:37 -0400 X-MC-Unique: 30uz0RfMNzC9PgkhK8RUUA-1 X-Mimecast-MFC-AGG-ID: 30uz0RfMNzC9PgkhK8RUUA_1744209815 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 75C131828A92; Wed, 9 Apr 2025 14:43:35 +0000 (UTC) Received: from p16v.luc.cera.cz (unknown [10.44.32.72]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4FDD91801747; Wed, 9 Apr 2025 14:43:31 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v2 08/14] mfd: zl3073x: Implement devlink device info Date: Wed, 9 Apr 2025 16:42:44 +0200 Message-ID: <20250409144250.206590-9-ivecera@redhat.com> In-Reply-To: <20250409144250.206590-1-ivecera@redhat.com> References: <20250409144250.206590-1-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Provide ASIC ID, ASIC revision, firmware version and optionally custom config version through devlink device info. Sample output: # devlink dev i2c/1-0070 # devlink dev info i2c/1-0070: driver zl3073x-i2c versions: fixed: asic.id 1E94 asic.rev 300 fw 7006 Signed-off-by: Ivan Vecera --- drivers/mfd/zl3073x-core.c | 75 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c index 28f28d00da1cc..79cf2ddbca228 100644 --- a/drivers/mfd/zl3073x-core.c +++ b/drivers/mfd/zl3073x-core.c @@ -10,7 +10,9 @@ #include #include #include +#include #include +#include #include #include #include "zl3073x.h" @@ -159,7 +161,80 @@ int zl3073x_write_reg(struct zl3073x_dev *zldev, unsigned int reg, } EXPORT_SYMBOL_GPL(zl3073x_write_reg); +/** + * zl3073x_devlink_info_get - Devlink device info callback + * @devlink: devlink structure pointer + * @req: devlink request pointer to store information + * @extack: netlink extack pointer to report errors + * + * Return: 0 on success, <0 on error + */ +static int zl3073x_devlink_info_get(struct devlink *devlink, + struct devlink_info_req *req, + struct netlink_ext_ack *extack) +{ + struct zl3073x_dev *zldev = devlink_priv(devlink); + u16 id, revision, fw_ver; + char buf[16]; + u32 cfg_ver; + int rc; + + guard(zl3073x)(zldev); + + rc = zl3073x_read_id(zldev, &id); + if (rc) + return rc; + + snprintf(buf, sizeof(buf), "%X", id); + rc = devlink_info_version_fixed_put(req, + DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, + buf); + if (rc) + return rc; + + rc = zl3073x_read_revision(zldev, &revision); + if (rc) + return rc; + + snprintf(buf, sizeof(buf), "%X", revision); + rc = devlink_info_version_fixed_put(req, + DEVLINK_INFO_VERSION_GENERIC_ASIC_REV, + buf); + if (rc) + return rc; + + rc = zl3073x_read_fw_ver(zldev, &fw_ver); + if (rc) + return rc; + + snprintf(buf, sizeof(buf), "%u", fw_ver); + rc = devlink_info_version_fixed_put(req, + DEVLINK_INFO_VERSION_GENERIC_FW, + buf); + if (rc) + return rc; + + rc = zl3073x_read_custom_config_ver(zldev, &cfg_ver); + if (rc) + return rc; + + /* No custom config version */ + if (cfg_ver == U32_MAX) + return rc; + + snprintf(buf, sizeof(buf), "%lu.%lu.%lu.%lu", + FIELD_GET(GENMASK(31, 24), cfg_ver), + FIELD_GET(GENMASK(23, 16), cfg_ver), + FIELD_GET(GENMASK(15, 8), cfg_ver), + FIELD_GET(GENMASK(7, 0), cfg_ver)); + + rc = devlink_info_version_running_put(req, "cfg.custom_ver", buf); + + return rc; +} + static const struct devlink_ops zl3073x_devlink_ops = { + .info_get = zl3073x_devlink_info_get, }; static void zl3073x_devlink_free(void *ptr) -- 2.48.1