Linux Hardening
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Brahmajit Das <listout@listout.xyz>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, clm@fb.com, josef@toxicpanda.com,
	dsterba@suse.com, kees@kernel.org, ailiop@suse.com,
	Mark Harmstone <mark@harmstone.com>
Subject: Re: [PATCH v3] btrfs: replace deprecated strcpy with strscpy
Date: Fri, 20 Jun 2025 14:27:15 +0200	[thread overview]
Message-ID: <20250620122715.GR4037@twin.jikos.cz> (raw)
In-Reply-To: <20250620014344.27589-1-listout@listout.xyz>

On Fri, Jun 20, 2025 at 07:13:44AM +0530, Brahmajit Das wrote:
> strcpy is deprecated due to lack of bounds checking. This patch replaces
> strcpy with strscpy, the recommended alternative for null terminated
> strings, to follow best practices.
> 
> There are instances where strscpy cannot be used such as where both the
> source and destination are character pointers. In that instance we can
> use sysfs_emit or a memcpy.
> 
> Update in v2: using sysfs_emit instead of scnprintf
> Update in v3: Removed string.h in xattr, since we are not using any
> fucntions from string.h and fixed length in memcpy in volumes.c

This should be placed under the "---" marker. If it's a new information
relevant for the patch then it should be a normal part of the changelog.

> No functional changes intended.

No need to write this.

> 
> Link: https://github.com/KSPP/linux/issues/88

No newline here.

> Suggested-by: Anthony Iliopoulos <ailiop@suse.com>
> Suggested-by: Mark Harmstone <mark@harmstone.com>
> Signed-off-by: Brahmajit Das <listout@listout.xyz>

Otherwise it looks good, thanks.

  parent reply	other threads:[~2025-06-20 12:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 14:06 [PATCH] btrfs: replace deprecated strcpy with strscpy Brahmajit Das
2025-06-19 15:39 ` [PATCH v2] " Brahmajit Das
2025-06-19 17:06   ` Mark Harmstone
2025-06-19 17:59     ` Brahmajit Das
2025-06-19 18:03       ` Mark Harmstone
2025-06-20  1:43   ` [PATCH v3] " Brahmajit Das
2025-06-20  5:15     ` Mark Harmstone
2025-06-20 12:27     ` David Sterba [this message]
2025-06-19 17:03 ` [PATCH] " Mark Harmstone
2025-06-19 18:02   ` Brahmajit Das
2025-06-20 12:24     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250620122715.GR4037@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=ailiop@suse.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=kees@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=listout@listout.xyz \
    --cc=mark@harmstone.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox