Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters

Luck, Tony
2025-12-19T16:21:45Z

On Fri, Dec 19, 2025 at 03:45:42PM +0300, Dan Carpenter wrote:
> On Fri, Dec 12, 2025 at 02:30:48AM +0900, Daniel Gomez wrote:
> > Maybe the flag fix just needs to be applied to the evaluation? Other op
> > structs do the same. But Dan's patch did not implement evaluate. E.g.:
> >
> > static struct symbol_op constant_p_op = {
> > .evaluate = evaluate_to_int_const_expr,
> > .expand = expand_constant_p
> > };
> >
>
> I was waiting for you to send this as a patch. I can do it if you
> need me to.

Dan,

Al Viro thought this was wrong. His alternative patch is here:

https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?id=2634e39bf02697a18fece057208150362c985992

-Tony