From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C992366DAD for ; Wed, 19 Nov 2025 19:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763581286; cv=none; b=JbcQh+A/s3GLsoUqyIU6ilEJfuFlripMVHhfvpy5SoR4c5DFpYB5QzUYY0uris41kGSj8/R2DrkSKhw1SjXs3fVIg1yLnc3bq12aVLwaGnKudNYmdxzSUyAuU3FyHaWj9y1MTZtI4ne0vkTypUYaplPffv0uB8ye3/FGOhQpTi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763581286; c=relaxed/simple; bh=McLj5MkyXM/EMQB5rQ6xp2qJjBV3WgZDPtIMlF++SQ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TPJvDXFnL/Oqb/YlqmXbr9nPPafcHKdT5gSBOwdaUMJ0b64wMLxQcJ1dUBIbkUeFDyd1qazVMiL/+sBGukPK748Yt+SM9hmCZNfjSsLRjYue65z30EzIfr+7vr82wltYJjL2EFnGVjWnOUw6JzvT3YO1t9syFjkU4yxOZ13+C+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=bPc6S0sG; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="bPc6S0sG" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-88051279e87so1038436d6.3 for ; Wed, 19 Nov 2025 11:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1763581282; x=1764186082; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1xvMcuBzJSIcfclCVWQ2hNnnKt+oezBHS+z89ygHsa4=; b=bPc6S0sGuHmGARD8ZnpZfpm34GFSkaMU4OFxV21xf8BCKqrDuDP5OSlnsvWhrOxRZX YRPZGnk4HlFvvfrXi4vurzIIFGZbdxPcBWTX8paU27knM2Uy0YyHUQaP/SbIe5tYs25M auLCKa71tmA4b9oRJB7tRbZCJ5gzfG5IYHiXSYTTvrXL0H7m47vcmEcSh1dC+tawQWXp YjgAR9cFyUPRlIPRLolCsiWYZyfCeOsDfnC5AVkjTKAOixK9O2mV1jUfpr7J66CPzf0b DyQjsItU8VvA+A+r0bVuLpQU8+5hX+La18EKV9zTuaWbH9eO0dxkCMXRfCZQsRcT1Z85 Faog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763581282; x=1764186082; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xvMcuBzJSIcfclCVWQ2hNnnKt+oezBHS+z89ygHsa4=; b=Y2cfzJDI5/A2b9wPcsiKYhMZ/UzWqpC1NIwHWNeFtZCXlMywJywYYmWdZeXhgfLaXX dN+OLbfTIFT75Q56qc+OeVxlnWgoRNuZ2mCMunigALiCqfCP1GNxyLuAy6S9xLwUWgoM u6iGkwTOrV8TpL7/uESVRS7qE2hOjIXIiZu1jA2JHeWvmhmCSokYBk7GMk37DsjorSyo bQCfMp8p2EIu3ZiEYGlN+yqt5zLYj1+laQ6cwW0txobA7XzmGxDhjqUuamPgO0ow5Yx/ A5VLDTyMNIjvLX3CBu7YdtYkVMnNZmoyPD/J/94bfdA1EkWT1nb29AxrKS50yhhZa6iy Yjrg== X-Forwarded-Encrypted: i=1; AJvYcCUOvuAdBiy27wgDimmdnLH5UxRO3FzgdMCMVQELuJT6XWqQo6ZSwzuJ1jRrNHeUiCvfU8+LipN2CseMP5pYUSM=@vger.kernel.org X-Gm-Message-State: AOJu0YwvHFFF5CCCbmwDJajxRtOotUhrXumAKUiR98/JMRoWVlaoI7mY bZ9TzZ7PErZHdlgE22hSb09MJidKTPUSaVjVl+I9bhr0rnP40W7R+I3GZAnRagj52IY= X-Gm-Gg: ASbGnctn1Rem+iX+/ITrLSj1qemxwZF64RB/252eJvbPvdvq4HEPae0xnA03MZ8f2GJ vrTxfXn4HbIr6OGAgyf4ygCYRamMRFMZn99PS+bhfpxpfDIcghlxWZ4L4J3bILJZACQFya/Cjm6 Z9tykL++jZSqWMm8BrohbZRpHK1TOAAqCG+iM5cPeM63923ts51+erI2cKC4pVgLL1AxRAJTfUy j/ZPuMzbRsvRaQ/jerYxeR7+aO1WO+VzGcbESk+3EAkLA0HRO4XhpuBevidtNIAmMj4YDKYU82v /2Dz4tTfPaLVOeJZ5vqqGvN+KznaB2ncqRr9VnItke0ERtDmZKGVArUs1T8+HxT7AY2BYJ9v+rj 2Sg9Iz/WPmGzAfaz7Gdxd/BN5EtRDU1cVA+HqXvEOrYTDRlyyCYArgYT0V4NoCdkh6BEuENOktj WLd/WLMk7MRX0oZOApp7bxlwyLkBbm3m8bL2EV73Q3uhH/jrE6K4BELm32 X-Google-Smtp-Source: AGHT+IEkkwKLlD7bgArhzanqcgyJXrNkTCLmX/zPs7UZp1FVMILPKD98FXvYwEVi1NAfBqdDip+8Dg== X-Received: by 2002:a05:6214:4a84:b0:7d2:f787:1978 with SMTP id 6a1803df08f44-8846ed7f961mr1725046d6.3.1763581281958; Wed, 19 Nov 2025 11:41:21 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8846e47115bsm1948696d6.21.2025.11.19.11.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 11:41:21 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vLo3M-00000000bbB-3imG; Wed, 19 Nov 2025 15:41:20 -0400 Date: Wed, 19 Nov 2025 15:41:20 -0400 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Jens Axboe , Robin Murphy , Joerg Roedel , Will Deacon , Marek Szyprowski , Andrew Morton , Jonathan Corbet , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Kees Cook , "Gustavo A. R. Silva" , Ankit Agrawal , Yishai Hadas , Shameer Kolothum , Alex Williamson , Krishnakant Jaju , Matt Ochs , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , "kvm@vger.kernel.org" , "linux-hardening@vger.kernel.org" , "Kasireddy, Vivek" Subject: Re: [PATCH v8 10/11] vfio/pci: Add dma-buf export support for MMIO regions Message-ID: <20251119194120.GR17968@ziepe.ca> References: <20251111-dmabuf-vfio-v8-0-fd9aa5df478f@nvidia.com> <20251111-dmabuf-vfio-v8-10-fd9aa5df478f@nvidia.com> <20251118142849.GG17968@ziepe.ca> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 18, 2025 at 11:56:14PM +0000, Tian, Kevin wrote: > > > > + down_write(&vdev->memory_lock); > > > > + list_for_each_entry_safe(priv, tmp, &vdev->dmabufs, dmabufs_elm) > > > > { > > > > + if (!get_file_active(&priv->dmabuf->file)) > > > > + continue; > > > > + > > > > + dma_resv_lock(priv->dmabuf->resv, NULL); > > > > + list_del_init(&priv->dmabufs_elm); > > > > + priv->vdev = NULL; > > > > + priv->revoked = true; > > > > + dma_buf_move_notify(priv->dmabuf); > > > > + dma_resv_unlock(priv->dmabuf->resv); > > > > + vfio_device_put_registration(&vdev->vdev); > > > > + fput(priv->dmabuf->file); > > > > > > dma_buf_put(priv->dmabuf), consistent with other places. > > > > Someone else said this, I don't agree, the above got the get via > > > > get_file_active() instead of a dma_buf version.. > > > > So we should pair with get_file_active() vs fput(). > > > > Christian rejected the idea of adding a dmabuf wrapper for > > get_file_active(), oh well. > > Okay then vfio_pci_dma_buf_move() should be changed. It uses > get_file_active() to pair dma_buf_put(). Makes sense, Leon can you fix it? Thanks, Jason