Re: [PATCH v3 1/2] lib: introduce simple error-checking wrapper for memparse()

Andy Shevchenko
2026-01-09T17:11:35Z

On Fri, Jan 09, 2026 at 02:41:55PM +0300, Dmitry Antipov wrote:
> On Thu, 2026-01-08 at 22:05 +0200, Andy Shevchenko wrote:

...

> > 2) missing Return section (run kernel-doc validator with -Wreturn,
> > for example).
>
> Good point. Should checkpatch.pl call kernel-doc (always or perhaps
> if requested using command-line option)?
>
> OTOH 1) lib/cmdline.c violates kernel-doc -Wreturn almost everywhere
> :-( and 2) IIUC this patch is already queued by Andrew.

Andrew's workflow allows folding / squashing patches.

> I would
> prefer to fix kernel-doc glitches immediately after memvalue() and
> its first real use case (presumably XFS) both reaches an upstream.

Logically we should fix existing problems first and then do not add more
(technical debt).

--
With Best Regards,
Andy Shevchenko