[PATCH] drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data

[PATCH] drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data

[Yicong Hui]

strcpy() is deprecated as it does not do any bounds checking (as
specified in Documentation/process/deprecated.rst).

There is a risk of buffer overflow in the case that the value for
THIS_MODULE->version exceeds the 64 characters. This is unlikely, but
replacing the deprecated function will pre-emptively remove this risk
entirely.

Replace both instances of strcpy() with the safer strscpy() function.

Changes have been compile tested.

Signed-off-by: Yicong Hui <yiconghui@gmail.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 47a6ce4fdc74..1c4e74e35cf3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -604,10 +604,10 @@ static int amdgpu_virt_write_vf2pf_data(struct amdgpu_device *adev)
 
 #ifdef MODULE
 	if (THIS_MODULE->version != NULL)
-		strcpy(vf2pf_info->driver_version, THIS_MODULE->version);
+		strscpy(vf2pf_info->driver_version, THIS_MODULE->version);
 	else
 #endif
-		strcpy(vf2pf_info->driver_version, "N/A");
+		strscpy(vf2pf_info->driver_version, "N/A");
 
 	vf2pf_info->pf2vf_version_required = 0; // no requirement, guest understands all
 	vf2pf_info->driver_cert = 0;
-- 
2.52.0

Re: [PATCH] drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data

[Kees Cook]

On Fri, Jan 09, 2026 at 04:25:14PM +0000, Yicong Hui wrote:
> strcpy() is deprecated as it does not do any bounds checking (as
> specified in Documentation/process/deprecated.rst).
> 
> There is a risk of buffer overflow in the case that the value for
> THIS_MODULE->version exceeds the 64 characters. This is unlikely, but
> replacing the deprecated function will pre-emptively remove this risk
> entirely.
> 
> Replace both instances of strcpy() with the safer strscpy() function.

This looks correct to me -- dest and src are both fixed-size, so strscpy
happily checks everything at compile time. :)

Reviewed-by: Kees Cook <kees@kernel.org>

-Kees

-- 
Kees Cook

Re: [PATCH] drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data

[Yicong Hui]

On 1/9/26 7:18 PM, Kees Cook wrote:
> On Fri, Jan 09, 2026 at 04:25:14PM +0000, Yicong Hui wrote:
>> strcpy() is deprecated as it does not do any bounds checking (as
>> specified in Documentation/process/deprecated.rst).
>>
>> There is a risk of buffer overflow in the case that the value for
>> THIS_MODULE->version exceeds the 64 characters. This is unlikely, but
>> replacing the deprecated function will pre-emptively remove this risk
>> entirely.
>>
>> Replace both instances of strcpy() with the safer strscpy() function.
> 
> This looks correct to me -- dest and src are both fixed-size, so strscpy
> happily checks everything at compile time. :)
> 
> Reviewed-by: Kees Cook <kees@kernel.org>
> 
> -Kees
> 

Hello!

Is there any further feedback or progress on this patch?

Thank you!
Yicong

Re: [PATCH] drm/amdgpu: Replace deprecated strcpy() in amdgpu_virt_write_vf2pf_data

[Alex Deucher]

On Wed, Mar 11, 2026 at 7:59 AM Yicong Hui <yiconghui@gmail.com> wrote:
>
> On 1/9/26 7:18 PM, Kees Cook wrote:
> > On Fri, Jan 09, 2026 at 04:25:14PM +0000, Yicong Hui wrote:
> >> strcpy() is deprecated as it does not do any bounds checking (as
> >> specified in Documentation/process/deprecated.rst).
> >>
> >> There is a risk of buffer overflow in the case that the value for
> >> THIS_MODULE->version exceeds the 64 characters. This is unlikely, but
> >> replacing the deprecated function will pre-emptively remove this risk
> >> entirely.
> >>
> >> Replace both instances of strcpy() with the safer strscpy() function.
> >
> > This looks correct to me -- dest and src are both fixed-size, so strscpy
> > happily checks everything at compile time. :)
> >
> > Reviewed-by: Kees Cook <kees@kernel.org>
> >
> > -Kees
> >
>
> Hello!
>
> Is there any further feedback or progress on this patch?

Applied.  Thanks. If any other patches slipped through the cracks,
please feel free to resend or ping on them.

Alex

>
> Thank you!
> Yicong