From: Rosen Penev <rosenp@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jeff Hugo <jeff.hugo@oss.qualcomm.com>,
Carl Vanderlip <carl.vanderlip@oss.qualcomm.com>,
Oded Gabbay <ogabbay@kernel.org>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-arm-msm@vger.kernel.org (open list:QUALCOMM CLOUD AI
(QAIC) DRIVER),
dri-devel@lists.freedesktop.org (open list:QUALCOMM CLOUD AI
(QAIC) DRIVER),
linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not
covered by other areas):Keyword:\b__counted_by(_le|_be)?\b)
Subject: [PATCH] accel/qaic: kcalloc + kzalloc to kzalloc
Date: Mon, 16 Mar 2026 17:30:34 -0700 [thread overview]
Message-ID: <20260317003034.71618-1-rosenp@gmail.com> (raw)
Combine allocations by using a flexible array member.
Use __counted_by for extra runtime analysis. Move counting variable
assignment as required by __counted_by.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/accel/qaic/qaic.h | 4 ++--
drivers/accel/qaic/qaic_drv.c | 7 ++-----
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/accel/qaic/qaic.h b/drivers/accel/qaic/qaic.h
index fa7a8155658c..e237020f6aa9 100644
--- a/drivers/accel/qaic/qaic.h
+++ b/drivers/accel/qaic/qaic.h
@@ -152,8 +152,6 @@ struct qaic_device {
struct list_head cntl_xfer_list;
/* Synchronizes MHI control device transactions and its xfer list */
struct mutex cntl_mutex;
- /* Array of DBC struct of this device */
- struct dma_bridge_chan *dbc;
/* Work queue for tasks related to MHI control device */
struct workqueue_struct *cntl_wq;
/* Synchronizes all the users of device during cleanup */
@@ -206,6 +204,8 @@ struct qaic_device {
void *ssr_mhi_buf;
/* DBC which is under SSR. Sentinel U32_MAX would mean that no SSR in progress */
u32 ssr_dbc;
+ /* Array of DBC struct of this device */
+ struct dma_bridge_chan dbc[] __counted_by(num_dbc);
};
struct qaic_drm_device {
diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c
index 63fb8c7b4abc..ab428ecd26f5 100644
--- a/drivers/accel/qaic/qaic_drv.c
+++ b/drivers/accel/qaic/qaic_drv.c
@@ -405,15 +405,12 @@ static struct qaic_device *create_qdev(struct pci_dev *pdev,
struct drm_device *drm;
int i, ret;
- qdev = devm_kzalloc(dev, sizeof(*qdev), GFP_KERNEL);
+ qdev = devm_kzalloc(dev, struct_size(qdev, dbc, 16), GFP_KERNEL);
if (!qdev)
return NULL;
- qdev->dev_state = QAIC_OFFLINE;
qdev->num_dbc = 16;
- qdev->dbc = devm_kcalloc(dev, qdev->num_dbc, sizeof(*qdev->dbc), GFP_KERNEL);
- if (!qdev->dbc)
- return NULL;
+ qdev->dev_state = QAIC_OFFLINE;
qddev = devm_drm_dev_alloc(&pdev->dev, &qaic_accel_driver, struct qaic_drm_device, drm);
if (IS_ERR(qddev))
--
2.53.0
next reply other threads:[~2026-03-17 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 0:30 Rosen Penev [this message]
2026-03-27 16:16 ` [PATCH] accel/qaic: kcalloc + kzalloc to kzalloc Jeff Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317003034.71618-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=carl.vanderlip@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=kees@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox