From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E47783C8713 for ; Thu, 14 May 2026 12:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778760865; cv=none; b=p9ivEuU89VMy65fdQrglaZ4ijyLA1rD7oOrbldgLUWk8bqcoAPhn7w88oZL2ixtwI6axE/Ysg9BTqMq5fRsK08qGUWgcpcRsZRfICa+UMXdcQVNZpf8AFghoEdtnZLoBdsIb457oUUXjWeKCeiOlLAtC6upWt6dJKqtj1nYF30o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778760865; c=relaxed/simple; bh=V0TkAqIwC1uY4UojH401/uSwLwk9fm4HWydEZTlvEmY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ue21I7EyI/QAJQclSFwbVodG4PHweBTWjpACisSDQxPkHo5WLA6tzwrhGAPn9afdnLao/doyZGnnYUKIr6SHDJlfgipPOe3OYTJmf4Vd/6yW1kEg0HiBPMoBSK76AZWask7RJErturn846Sxc59XOrC+jHHXbAPzulFsZCO0/BE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMJAmtsa; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMJAmtsa" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488ad135063so64539725e9.0 for ; Thu, 14 May 2026 05:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778760861; x=1779365661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VRooYCCfpJIXVfO+TbuD+FrPZ3PAKdcOterQ+HA71Ww=; b=cMJAmtsaxMivWG1RHIHvEXj19EZ5yO5Xp19dmJd1IKGPykE/rVSfUWm7otIxJrgg/J HbET1DFu/yXbBY2g6nVa1J3h6SJUxog3U2zhwYxBhdFWqNxKXFkGgcbs14jaJoDUeZVi r2s+UXXKfzI0wJhA6jciEuP35Ipf2c1tip4xB48BjJIbR0WZWz5qEIU6vnp+HnhDr/fY OzOklOGIZHVdWOsS4ajJJ3iGAr0ZEAe7EOnkfSlS4svB+25GjbwMuL0Ywp1N3/aGrX3y tqKSXzqF/KLy1lhXlV3xdbh8tULgjAsvP/nheMOnYjlSGvhJbCCw5rgJSPJ0ILIl+n2L /A+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778760861; x=1779365661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VRooYCCfpJIXVfO+TbuD+FrPZ3PAKdcOterQ+HA71Ww=; b=AIwGdRacbBP6PHSKy1+sTELgAwenjrDiAbB6wiIyJhO4dqDf29B794Fb3nSOk1MUb9 AzTexT78N5RdK5n6iHPxCI9rBOHLqNmMH7AIaRym5Q+LMXla0X0RnNjg26w36Gkz4wz8 8fACjStWsxrDzBznw58NJshGlguG4yttkO62g/I29AAsNDs+0Z7FlE58NocWAc5ts/OA jy8w3GXE+NBM/87HnP2o1xypIzSD4X1jfp0nKby55UYeJqQjhc+o34ozqCZ8YtEjE+zN 9TOtmc5DnqVPeLrmNJr7OLv8uGLXVNI2QPHiAZaensR4wXPgkLIj5Mq/CSk8m/7ZMSkq MKhQ== X-Forwarded-Encrypted: i=1; AFNElJ8XtcDb3wPvQLTeoI7CfIXOEJjSbgrDH+selxNds3PxlDfPsYeSO5JXkQHyFjFuITYfD4BrOY2kl2NnP9cI810=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr6imHJCY8/5FpcNhhwgyQoY3fuYSFkIXTuLFLnEy1o9onBjWk bvJYXTNI/QLpZ9OHdVefICaSo1DdECURTPNrApOJwg3yBTo+4P231TV/ X-Gm-Gg: Acq92OHh/+Ojr7fmxDbtCX2byUhS6XDEZPuY1v5hP3fmq3MdONZrnknMF5gS/KTPc8+ NwpAunBxnB7qkZOtj5vBsNcRm3y8Z1OY6WbNSQaReBpN4sbPbvE1UpSwR/FcDTvgrKjGmtlhart ueCmeGBVlQrp3/WWWwks8u+Bp552fp6J7GS/tIQQL8NtsfiRUTwrZPd8/QH7BbbnsSAyRY9fE81 WPKRKT8zLt6pMCSqwjo4L1F9THcEkmF78MvD8U82c/P/Lj22+hnVrM1gdqA02fFnEkRIdnaxFuX OIMctJbyssGz8kBeKsOmrHYOHl3pYG5H1mm3hWySiuRc/9pYFiTPNDEDd3GhnGjUS1JirNakowK DnBPx+WAph+6IF7+wLnMgeg07I/S7sa2Rx0MJv/mpp7uxnG7OMDAq4pd2xEhDwNaWTGOD/L6dop RjCPLOJo383qyQYtUwgVzt/E2iz+UDiYgpjKvYPdyu7MvbLpy0yYXkjAwehF6S4/g= X-Received: by 2002:a05:600c:45c8:b0:48d:35e:84a0 with SMTP id 5b1f17b1804b1-48fcea151fbmr104364665e9.28.1778760861344; Thu, 14 May 2026 05:14:21 -0700 (PDT) Received: from RTRKW671-LIN.domain.local ([77.243.27.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e767cb9sm6285630f8f.2.2026.05.14.05.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 05:14:20 -0700 (PDT) From: Milan Tripkovic To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Alexandre Ghiti , Kees Cook , Andy Shevchenko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Dusan Stojkovic , Milan Tripkovic , kernel test robot Subject: [PATCH v2 2/2] lib/string_kunit: extend benchmarks and unit test to memcmp() Date: Thu, 14 May 2026 14:13:58 +0200 Message-ID: <20260514121359.931999-3-milant2002@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260514121359.931999-1-milant2002@gmail.com> References: <20260514121359.931999-1-milant2002@gmail.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Milan Tripkovic Extend the string benchmarking suite to include memcmp(). Extend the string unit test to include memcmp(). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202605140827.Qg1DZpcB-lkp@intel.com/ Signed-off-by: Milan Tripkovic --- lib/tests/string_kunit.c | 106 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/lib/tests/string_kunit.c b/lib/tests/string_kunit.c index 0819ace5b027..d0bad40a719a 100644 --- a/lib/tests/string_kunit.c +++ b/lib/tests/string_kunit.c @@ -881,6 +881,110 @@ static void string_bench_strrchr(struct kunit *test) STRING_BENCH_BUF(test, buf, len, strrchr, buf, '\0'); } +static void string_test_memcmp(struct kunit *test) +{ + const int max_offset = 16; + const int max_len = 32; + const int buf_size = max_offset + max_len + 32; + u8 *buf1, *buf2; + int i, j, len, k; + + buf1 = kunit_kzalloc(test, buf_size, GFP_KERNEL); + buf2 = kunit_kzalloc(test, buf_size, GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf1); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf2); + + for (i = 0; i < max_offset; i++) { + for (j = 0; j < max_offset; j++) { + for (len = 0; len <= max_len; len++) { + memset(buf1, 'A', buf_size); + memset(buf2, 'A', buf_size); + KUNIT_EXPECT_EQ_MSG(test, memcmp(buf1 + i, buf2 + j, len), 0, + "Should be equal: i:%d j:%d len:%d", i, j, len); + for (k = 0; k < len; k++) { + memset(buf1, 'A', buf_size); + memset(buf2, 'A', buf_size); + buf2[j + k] = 'B'; + int res = memcmp(buf1 + i, buf2 + j, len); + + KUNIT_EXPECT_NE_MSG(test, res, 0, + "Should detect difference at k:%d (i:%d j:%d len:%d)", + k, i, j, len); + + if (buf1[i + k] < buf2[j + k]) + KUNIT_EXPECT_LT(test, res, 0); + else + KUNIT_EXPECT_GT(test, res, 0); + } + } + } + } +} + +#if IS_ENABLED(CONFIG_STRING_KUNIT_BENCH) +static void string_bench_memcmp(struct kunit *test) +{ + char *buf1, *buf2; + size_t lengths[] = { 1, 7, 8, 16, 32, 64, 128, 512, 1024, 4096}; + int offsets[] = {0, 1, 3, 7}; + const size_t max_len = 4096 + 64; + + buf1 = vmalloc(max_len); + buf2 = vmalloc(max_len); + + if (!buf1 || !buf2) { + vfree(buf1); + vfree(buf2); + kunit_err(test, "vmalloc failed\n"); + return; + } + + memset(buf1, 'A', max_len); + memset(buf2, 'A', max_len); + + for (int i = 0; i < 100000; i++) + (void)memcmp(buf1, buf2, 4096); + + for (int o = 0; o < ARRAY_SIZE(offsets); o++) { + int off = offsets[o]; + + for (int i = 0; i < ARRAY_SIZE(lengths); i++) { + size_t len = lengths[i]; + char *p1 = buf1; + char *p2 = buf2 + off; + + u32 iterations = (len < 512) ? 100000 : 10000; + + for (u32 j = 0; j < iterations; j++) { + (void)memcmp(p1, p2, len); + barrier(); + } + + u64 elapsed = STRING_BENCH(iterations, memcmp, p1, p2, len); + u64 ns_per_call = div_u64(elapsed, iterations); + u64 mbps = len ? div_u64((u64)len * iterations * 1000, + elapsed) : 0; + + if (off == 0) { + kunit_info(test, "bench_memcmp_aligned: len=%-4zu: %llu MB/s (%llu ns/call)\n", + len, mbps, ns_per_call); + } else { + kunit_info(test, "bench_memcmp_unaligned(off=%d): len=%-4zu: %llu MB/s (%llu ns/call)\n", + off, len, mbps, ns_per_call); + } + } + } + + vfree(buf1); + vfree(buf2); +} +#else +static void string_bench_memcmp(struct kunit *test) +{ + kunit_skip(test, "not enabled"); +} +#endif + static struct kunit_case string_test_cases[] = { KUNIT_CASE(string_test_memset16), KUNIT_CASE(string_test_memset32), @@ -910,6 +1014,8 @@ static struct kunit_case string_test_cases[] = { KUNIT_CASE(string_bench_strnlen), KUNIT_CASE(string_bench_strchr), KUNIT_CASE(string_bench_strrchr), + KUNIT_CASE(string_test_memcmp), + KUNIT_CASE_SLOW(string_bench_memcmp), {} }; -- 2.43.0