From: Milan Tripkovic <milant2002@gmail.com>
To: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
kees@kernel.org
Cc: alex@ghiti.fr, andy@kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
Dusan.Stojkovic@rt-rk.com, Milan Tripkovic <milant2002@gmail.com>,
Milan Tripkovic <Milan.Tripkovic@rt-rk.com>
Subject: [PATCH v6 0/2] riscv: lib: add optimized memcmp() and extend KUnit tests
Date: Wed, 20 May 2026 14:39:52 +0200 [thread overview]
Message-ID: <20260520123954.379630-1-milant2002@gmail.com> (raw)
This v6 series provides an optimized RISC-V memcmp() implementation
along with extended KUnit tests for functional verification and
benchmarking
The memcmp() implementation now uses word-aligned loads for the generic
path and leverages Zbb for fast sign resolution on supported hardware.
A robust fallback to byte-by-byte comparison is implemented for non-Zbb
systems to ensure correctness and stability across different toolchains
and hardware revisions.
Signed-off-by: Milan Tripkovic <Milan.Tripkovic@rt-rk.com>
---
v6 changes:
- Fixed build errors kernel test robot noticed.
- Link to v5: https://lore.kernel.org/all/20260519140029.1190381-1-milant2002@gmail.com/
v5 changes:
- Removed redundant warm-up from test case
- Optimized generic memcmp path with word-aligned loads.
- Implemented non-ZBB fallback to byte comparison per review.
- Link to v4: https://lore.kernel.org/all/20260518131407.1026049-2-milant2002@gmail.com/
v4 changes:
- Fixed build error: call to undeclared function 'STRING_BENCH'
- Link to v3: https://lore.kernel.org/all/20260515141019.1234037-1-milant2002@gmail.com/
v3 changes:
- Split memcmp benchmark into wrapper (string_bench_memcmp) and worker
function (do_string_bench_memcmp).
- Removed all C99 mixed declarations; moved all variable declarations
to the top of each function.
- Converted len, iterations and loop counters in the benchmark to u64
to avoid implicit casts.
- Cleaned up spacing, indentation and minor style issues.
- Added #if defined(CONFIG_RISCV_ISA_ZBB)... in memcmp.S
- Link to v2: https://lore.kernel.org/all/20260514121359.931999-1-milant2002@gmail.com/
v2 changes:
- Added alignment checks for buffers to avoid expensive misaligned loads.
- Optimized the loop using end-pointers to reduce per-iteration overhead.
- Implemented word-aligned tail handling using ZBB shifts.
- Removed redundant pointer equality (a0 == a1) check.
- Retained BE support via #ifndef; ZBB rev8 is used for the LE fast-path.
- Fixed KUnit build failures for Clang and non-benchmark configs.
- Link to v1: https://lore.kernel.org/all/20260512141007.1193033-1-milant2002@gmail.com/
Milan Tripkovic (2):
riscv: lib: add memcmp() implementation
lib/string_kunit: extend benchmarks and unit test to memcmp()
arch/riscv/include/asm/string.h | 2 +
arch/riscv/lib/Makefile | 1 +
arch/riscv/lib/memcmp.S | 107 ++++++++++++++++++++++++++++++++
arch/riscv/purgatory/Makefile | 5 +-
lib/tests/string_kunit.c | 106 +++++++++++++++++++++++++++++++
5 files changed, 220 insertions(+), 1 deletion(-)
create mode 100644 arch/riscv/lib/memcmp.S
--
2.43.0
next reply other threads:[~2026-05-20 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 12:39 Milan Tripkovic [this message]
2026-05-20 12:39 ` [PATCH v6 1/2] riscv: lib: add memcmp() implementation Milan Tripkovic
2026-05-20 12:39 ` [PATCH v6 2/2] lib/string_kunit: extend benchmarks and unit test to memcmp() Milan Tripkovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520123954.379630-1-milant2002@gmail.com \
--to=milant2002@gmail.com \
--cc=Dusan.Stojkovic@rt-rk.com \
--cc=Milan.Tripkovic@rt-rk.com \
--cc=alex@ghiti.fr \
--cc=andy@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox