From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C170D41E6A7 for ; Tue, 4 Aug 2026 21:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785877662; cv=none; b=O46fD200RQL3lky/FPhv7WmA/hEdLEQ7wpBykUFL9Jx93hutsFmRKHmU7KEryw4aVxJBqMA3/Rz0OfVPdKDXxe+LwOKzFNn3Vo4tAcG9zeTrl1apt7CL3m0VfC7WT0tTQ7/EZp24SjUBHCKuXaSrhyYMmCfnY63qsep8XTz76Is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785877662; c=relaxed/simple; bh=M94F1PqXP2R4azTv5VsBrw3fcVY3YhyrZvCDUpvojig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=McVppQqnG1A2ghzFSpL/oxWLelnZhzbAZ4Jri5QuMSZnfJU84f10WPhVL0EBLVm9tWKSl7oSs0acOi40IPyzFmQgr6e2aM1vC7+iXWU2RT2v0lCF8io/Rohkf3PPRK38kC+H5f6tzMQ5uBV8PayPQ1vuic2jkF4ZKiH5m7QIAEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s/JyTPzm; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s/JyTPzm" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8486ac3f347so1607971b3a.1 for ; Tue, 04 Aug 2026 14:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785877660; x=1786482460; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5VUaS6lIR89fzUXE8jE1kCkmVqVFSCHPmmwJhW/Xieo=; b=s/JyTPzmzEy4CYMFx0MDLuGE+Hz9l9t0GpvdDSsuX6ku14z12aoaDR2OJu60H7O8VP 1fl5KymTjLMPLGt4YuDWeSSUZdNkRrIWHhaB2fwnW6LxD33/8HSOxRMuxD36+cIAeSFs oAWrzA2+GfzsqWbs2n5swGClIIwf+vZo48iZgoxXV6+Um2UP1QeHj69XQ68xUcm6E7Zr Dz+nSSlWrsUXfnFYtukGJgoQ4RDl/bNZNIt2MbviTqPz/56gAHTX4OaF62Ipi1qUlPkN rJc//7Le8rHgmUaIxWbz3FO9JAeIRxzpT5Nj4qO5sD//y0RXvFTgzxLJyNXJAhhpoYG+ PRQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785877660; x=1786482460; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5VUaS6lIR89fzUXE8jE1kCkmVqVFSCHPmmwJhW/Xieo=; b=Lj2hS56leYN4iZN87HUZyNH+aBP11pul5E11RmTnoUjMXbkXJdf3qfKKYkuAxy+RSb VJRFuYA/JrJxrh2kXwX7kKOfZ5aPnY1w0JUW+wpYDWWzsXm2RzlcGOWYTFr+gN4mAJjV r/thrkCj15IC5GUXnakrLd2J4sSusi6LxJotzMCzwCnBwyqQMkTPlRFQGI17M6dizIse SthNbG6HeANiGJzzt7hJuUf/hKCxcjAjR8QiaVYD1QzTrcYfWX7E5Ezuf578Pzi98y5R 53gwkMJ8lqPETu6LA1tImv27tzBVIpnhm+p3vcVQ2wM3rFVuRM4zhDtLHJe0qLIMOzXd wt/w== X-Forwarded-Encrypted: i=1; AHgh+RqFw0apNznNqoc5uupZIAalQGwfJjWy3wOtPIHD40Z4MWIPMAFzqB2mjeRNjLP7YaW3+lnqFxezGV3Jci2b6NI=@vger.kernel.org X-Gm-Message-State: AOJu0YzGQzu2yAZvPvV3wgmpmCD7QmkRsEqNoV4XdkF4bNcKjxczPC9Q /aAmso/LarKOzs5Z/EERPyLmbM6ODhhEwuk0Z0OeyX1VrxTzXgwMB5IV X-Gm-Gg: AR+sD100Ood9vcPqHAFY7B7Hk6THW04xkNPzX8eAXypphzuhAQUyXfHnXv/H3a4luZN 9fnAhg6nepWAARyFL/R6sO1BdTuPZAZPswUiwCxLBPaib+41hLBT67VrQe1e5HqvRkni3yp5OI/ SmljI0mP07/aCA0FSnJMSVE4JFtrwnttGbsYa8b2ihoIeephesQwQsquAAGc3iE6iTTQCMWgbdY u6QQq7+jwmK6rAh0lwO9Ufgpb6cwRSbAKG+mnNeIkIqIeDuyItiH9kUR5tl/zalbZOCirG1A7pI BvAj5HyeaodwdKlI/HoLW8TYYnMcbtfwN6YfTdznHD4hkqL1m8yczjoptI5O2QalIYIxGpGmVq4 CZO6S9hGOxHxRLoLbzfnAyZBGEAmYDeBgPiTQlwil2yoruRC38BYOdFWgnC5rC4f0x6cM7g40ve XRGANuNwuAV8wm9Pj1UYxc0tKyx3HGix7QvsYXX4IwrFMqImp0GP0WmaRlhN/kqBwK1BN2z0p3t GujRml0REtopg== X-Received: by 2002:a05:6a20:4320:b0:3c4:3750:2c03 with SMTP id adf61e73a8af0-3cb6c7b71b0mr5878476637.9.1785877660120; Tue, 04 Aug 2026 14:07:40 -0700 (PDT) Received: from localhost.localdomain ([12.162.234.74]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fca6576b7sm6062339c88.7.2026.08.04.14.07.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 04 Aug 2026 14:07:39 -0700 (PDT) From: Ahmad Byagowi To: Vadim Fedorenko Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Peter Rosin , Nam Tran , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kees Cook , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RFC net-next v2 4/6] ptp: ocp: Validate EEPROM board IDs Date: Tue, 4 Aug 2026 14:07:35 -0700 Message-ID: <20260804210735.48116-1-ahmadexp@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <4ef01fa0-969f-4ec0-997b-5f5f3f67e11a@linux.dev> References: <20260803205011.1249-1-ahmadexp@gmail.com> <20260803205011.1249-5-ahmadexp@gmail.com> <4ef01fa0-969f-4ec0-997b-5f5f3f67e11a@linux.dev> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks for the review. Agreed, I will use the 12-character Fixes hash and split this safety fix from the feature series so it can target net. One detail about the suggested snprintf(): the size argument limits writes to buf, but a plain %s still scans bp->board_id for a NUL beyond its fixed 13-byte storage. I reused buf with a precision-bounded conversion instead: snprintf(buf, sizeof(buf), "%.*s", OCP_BOARD_ID_LEN, (const char *)bp->board_id); I have reduced this to a standalone net patch containing only the over-read fix. I will rebase the remaining R4006 and V9 feature series onto net-next after the fix reaches it. Thanks, Ahmad