From: Kees Cook <kees@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: tony.luck@intel.com, linux-hardening@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net
Subject: Re: [PATCH 0/2] Small improvements on pstore user experience
Date: Wed, 23 Sep 2026 00:20:01 -0700 [thread overview]
Message-ID: <202609230016.101B0479BF@keescook> (raw)
In-Reply-To: <20260922212532.98571-1-gpiccoli@igalia.com>
On Tue, Sep 22, 2026 at 06:19:00PM -0300, Guilherme G. Piccoli wrote:
> Hi Kees, Tony,
>
> Here are some small things I've noticed in pstore usage that annoyed
> me a bit, so it's not they must be fixed - no bugs here that I can't see.
>
> But the fact kmsg_bytes can be changed via mount option but I can't
> write on its sysfs parameter, or that I can set compression to like
> "zstd" even when PSTORE_COMPRESS is unset, is a bit confusing to the
> point I tried to improve them with these patches heh
Thanks for poking at it! Yeah, that PSTORE_COMPRESS=n seems like it
needs to get fixed. :P
> Thanks for reviews and comments, and feel free to reject them if in
> your opinion, they make things worse.
Sashiko has some notes:
https://sashiko.dev/#/patchset/20260922212532.98571-1-gpiccoli%40igalia.com
I fear it is uncovered some other (small) preexisting issues, but I do
agree the kmsg_bytes concurrency race is troublesome.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2026-09-23 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:19 [PATCH 0/2] Small improvements on pstore user experience Guilherme G. Piccoli
2026-09-22 21:19 ` [PATCH 1/2] pstore: Consolidate compression handling in both init paths Guilherme G. Piccoli
2026-09-22 21:19 ` [PATCH 2/2] pstore: Allow kmsg_bytes parameter to be written at runtime Guilherme G. Piccoli
2026-09-23 7:20 ` Kees Cook [this message]
2026-09-23 14:30 ` [PATCH 0/2] Small improvements on pstore user experience Guilherme G. Piccoli
2026-10-06 20:35 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609230016.101B0479BF@keescook \
--to=kees@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-hardening@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox