From: Janosch Frank <frankja@linux.ibm.com>
To: Kees Cook <keescook@chromium.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
Steffen Eiden <seiden@linux.ibm.com>
Subject: Re: [PATCH] selftests: drivers/s390x: Use SKIP() during FIXTURE_SETUP
Date: Tue, 4 Jun 2024 09:24:47 +0200 [thread overview]
Message-ID: <211b39ae-af0c-4db9-8931-a1446f34c832@linux.ibm.com> (raw)
In-Reply-To: <20240518001806.work.381-kees@kernel.org>
On 5/18/24 02:18, Kees Cook wrote:
> Instead of mixing selftest harness and ksft helpers, perform SKIP
> testing from the FIXTURE_SETUPs. This also means TEST_HARNESS_MAIN does
> not need to be open-coded.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
Adding the author in CC.
This changes the skip behavior from one single skip to a skip per test.
Not an issue, but a change.
But also we're generating invalid TAP AFAIK which we also have been
before but we can fix that in this patch.
From what I understand this line should have a "#" prefix to show that
it's a comment:
Enable CONFIG_S390_UV_UAPI and check the access rights on /dev/uv.
prev parent reply other threads:[~2024-06-04 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 0:18 [PATCH] selftests: drivers/s390x: Use SKIP() during FIXTURE_SETUP Kees Cook
2024-06-04 7:24 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211b39ae-af0c-4db9-8931-a1446f34c832@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=seiden@linux.ibm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox