Re: [PATCH][next] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings

Gustavo A. R. Silva
2025-12-19T04:35:23Z

On 12/19/25 13:29, Zhu Yanjun wrote:
>
> 在 2025/12/18 18:51, Gustavo A. R. Silva 写道:
>>
>>
>> On 12/19/25 04:22, Yanjun.Zhu wrote:
>>>
>>> On 12/18/25 7:56 AM, Leon Romanovsky wrote:
>>>> On Sun, Dec 14, 2025 at 09:00:51PM -0800, Zhu Yanjun wrote:
>>>>>
>>>>> 在 2025/12/5 20:41, Zhu Yanjun 写道:
>>>>>>
>>>>>> 在 2025/12/4 9:48, yanjun.zhu 写道:
>>>>>>> On 12/4/25 5:05 AM, Jason Gunthorpe wrote:
>>>>>>>> On Wed, Dec 03, 2025 at 09:08:45PM -0800, Zhu Yanjun wrote:
>>>>>>>>>>         unsigned int res_head;
>>>>>>>>>>         unsigned int        res_tail;
>>>>>>>>>>         struct resp_res        *res;
>>>>>>>>>> +
>>>>>>>>>> +    /* SRQ only. srq_wqe.dma.sge is a flex array */
>>>>>>>>>> +    struct rxe_recv_wqe srq_wqe;
>>>>>>>>> drivers/infiniband/sw/rxe/rxe_resp.c: In function get_srq_wqe:
>>>>>>>>> drivers/infiniband/sw/rxe/rxe_resp.c:289:41: error: struct
>>>>>>>>> rxe_recv_wqe has
>>>>>>>>> no member named wqe
>>>>>>>>>     289 |         qp->resp.wqe = &qp->resp.srq_wqe.wqe;
>>>>>>>>>         |                                         ^
>>>>>>>> I didn't try to fix all the typos, you will need to do that.
>>>>>>> Exactly. I will fix this problem. This weekend, I will send out an
>>>>>>> official commit.
>>>>>> Hi, Jason
>>>>>>
>>>>>> The followings are based on your commits and Leon's commits. And it can
>>>>>> pass the rdma-core tests.
>>>>>>
>>>>>> I am not sure if this commit is good or not.
>>>>> Hi, Jason && Leon
>>>>>
>>>>> Any update? If this looks good to you, I will send out an official commit
>>>>> based on the following commit.
>>>> You are RXE maintainer, send the official patch.
>>>
>>> Will do. I will send it out very soon.
>>
>> I don't see how this addresses the flex-array in the middle issue that
>> originated this discussion.
>
> Could you please explain this in more detail?
> Also, if you have a better approach, would you mind sending a new commit for discussion?

This is exactly what my original patch is about. I've explained this a couple of times
in this thread already.

-Gustavo