public inbox for linux-hardening@vger.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <laniel_francis@privacyrequired.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
	davem@davemloft.net, keescook@chromium.org
Subject: Re: [RESEND,net-next,PATCH v5 0/3] Fix inefficiences and rename nla_strlcpy
Date: Mon, 16 Nov 2020 19:17:17 +0100	[thread overview]
Message-ID: <2952773.LrNCO7Tzqc@machine> (raw)
In-Reply-To: <20201116092247.608b4f0d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Le lundi 16 novembre 2020, 18:22:47 CET Jakub Kicinski a écrit :
> On Sun, 15 Nov 2020 18:08:03 +0100 laniel_francis@privacyrequired.com
> 
> wrote:
> > This patch set answers to first three issues listed in:
> > https://github.com/KSPP/linux/issues/110
> > 
> > To sum up, the patch contributions are the following:
> > 1. the first patch fixes an inefficiency where some bytes in dst were
> > written twice, one with 0 the other with src content.
> > 2. The second one modifies nla_strlcpy to return the same value as
> > strscpy,
> > i.e. number of bytes written or -E2BIG if src was truncated.
> > It also modifies code that calls nla_strlcpy and checks for its return
> > value. 3. The third renames nla_strlcpy to nla_strscpy.
> > 
> > Unfortunately, I did not find how to create struct nlattr objects so I
> > tested my modifications on simple char* and with GDB using tc to get to
> > tcf_proto_check_kind.
> > 
> > If you see any way to improve the code or have any remark, feel free to
> > comment.
> > 
> > 
> > Best regards and take care of yourselves.
> 
> Applied, thank you!

Perfect! You are welcome!




      reply	other threads:[~2020-11-16 18:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 17:08 [RESEND,net-next,PATCH v5 0/3] Fix inefficiences and rename nla_strlcpy laniel_francis
2020-11-15 17:08 ` [RESEND,net-next,PATCH v5 1/3] Fix unefficient call to memset before memcpu in nla_strlcpy laniel_francis
2020-11-15 17:08 ` [RESEND,net-next,PATCH v5 2/3] Modify return value of nla_strlcpy to match that of strscpy laniel_francis
2020-11-15 17:08 ` [RESEND,net-next,PATCH v5 3/3] treewide: rename nla_strlcpy to nla_strscpy laniel_francis
2020-11-16 17:22 ` [RESEND,net-next,PATCH v5 0/3] Fix inefficiences and rename nla_strlcpy Jakub Kicinski
2020-11-16 18:17   ` Francis Laniel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2952773.LrNCO7Tzqc@machine \
    --to=laniel_francis@privacyrequired.com \
    --cc=davem@davemloft.net \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox