linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Stanislaw Gruszka <stf_xl@wp.pl>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings
Date: Wed, 27 Aug 2025 12:05:18 +0200	[thread overview]
Message-ID: <2b54967e-bd1f-4ad9-bba7-aa05bf3d1e7c@embeddedor.com> (raw)
In-Reply-To: <0ef7587b7ae57d9363312ca130980707a68a3f7e.camel@sipsolutions.net>



On 27/08/25 11:36, Johannes Berg wrote:
> On Wed, 2025-08-27 at 11:25 +0200, Gustavo A. R. Silva wrote:
>> Friendly
> 
> I contest that. It's been two weeks, while it's still summer with

Sorry, I don't really know when people around the globe are on vacation
or not. I don't think we're based in the same area, so our customs may
vary.

> vacations etc., not long after the merge window closed, with weeks to go
> until the next release comes around. Why are you impatient?

Apparently (and according to git blame), the last person that committed a
change to this file was Greg KH back in 2019, see: commit 16da78b7b580e
("treewide: Replace GPLv2 boilerplate/ reference with SPDX - rule 270").

So, rather than impatience is more about not really knowing who's maintaining
this file.

> 
> I will take it. Eventually, the more you push the less I want to. And

Not sure what to make of this. I'm just doing my work and trying to
collaborate with people. I expect all my comments here clarify the
reason for the ping.

> it'd help if you actually followed our conventions and used 'wifi:'
> prefix.

Related to my comments above, you're not listed as a maintainer of this
file. If you were, I'd have probably remembered that.

scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
Stanislaw Gruszka <stf_xl@wp.pl> (maintainer:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-wireless@vger.kernel.org (open list:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-kernel@vger.kernel.org (open list)
INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy) status: Supported

In any case, thanks for your response.
-Gustavo

      reply	other threads:[~2025-08-27 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11  5:10 [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-08-22  7:14 ` Stanislaw Gruszka
2025-08-27  9:25 ` Gustavo A. R. Silva
2025-08-27  9:36   ` Johannes Berg
2025-08-27 10:05     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b54967e-bd1f-4ad9-bba7-aa05bf3d1e7c@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stf_xl@wp.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).