From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265CF85654 for ; Wed, 7 Aug 2024 20:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.89.44.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723063410; cv=none; b=kC9HftAu0aWa7aBQADLzYjSmDYfKGq3ekS5gXgqovl1ZJ2ie8N+25MTQ5jDZDo4APYCM+mleT7cHDdqe0g+Fyk9iqlD51jwk268stkuGONSd4n2d4vQviIgQXhW534B23OukL/bT9TH6BoQBEppGbHaAxuZfn7HLBRJiBr/clSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723063410; c=relaxed/simple; bh=TUdmzF4Dz7pi04rHPVvMU10XnGbfRwdQqk8C4Hwo1mg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZcQENtj1vJUHQXFOq97/cJAmrW0hmrHYXI1F6nJ6UX/p8rftIhjEFxDUbntYSPEouPfi9hc/v60EMeDO+Y1ubt3WOG1S+mokCVVLlb2YSNWlgmXKduBWbDhXUYXpm1S3lvU+Njuw/cE3gC3QJjmr9ShS4kjjZa8axpYEGv6pYxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=xMvaotYz; arc=none smtp.client-ip=35.89.44.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="xMvaotYz" Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id beOhsFnCAVpzpbnVHse1wm; Wed, 07 Aug 2024 20:43:27 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id bnVGsCe5j5D6dbnVGsRJAM; Wed, 07 Aug 2024 20:43:26 +0000 X-Authority-Analysis: v=2.4 cv=I6GuR8gg c=1 sm=1 tr=0 ts=66b3dc6e a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=frY+GlAHrI6frpeK1MvySw==:17 a=IkcTkHD0fZMA:10 a=yoJbH4e0A30A:10 a=OgNgpzeeqhBM75w_DO4A:9 a=QEXdDO2ut3YA:10 a=Xt_RvD8W3m28Mn_h3AK8:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8meIjU4p2sBqnFEM+5AxNwgHdl5Y20EE/5kwe2KxHEA=; b=xMvaotYzL+yiEzCGrCWW+wHEAc MXpPO0kieNg0j3f5pkp45kfgOiLw9RjCYMqVg0Ecck2PA7nJbSGlpWSC5XPH0j+ZdJC2tdoTUYLZl yqeobpBM5OyStjnukI5+06cRPv4qRaJWND2oLDK/Tg/t+uGIRUYgXWOvpBgU9DMgWN2oPzy+Ph3MZ vKrVOS3HFZhPxc+66Hx4qNdy7EthAzk7+0nNMQbj4Y52tUi9QLnGVK1PDPa5u8vVNCy79hTuPcVu4 OJuXzx7tArnTFqDdmG6s2YzZWSaQXjYBZqKTl6rbaYYu17lsTylyzHjsL204zaR/4sLYbOJX81ueE ShACXJ3Q==; Received: from [201.172.173.139] (port=48540 helo=[192.168.15.5]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1sbnVF-004IhR-2N; Wed, 07 Aug 2024 15:43:25 -0500 Message-ID: <41c0cb7a-6fd4-4757-8d1a-7466fa268666@embeddedor.com> Date: Wed, 7 Aug 2024 14:43:24 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] rpmsg: glink: Avoid -Wflex-array-member-not-at-end warnings To: Kees Cook , "Gustavo A. R. Silva" Cc: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <202404290937.C22567C1@keescook> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <202404290937.C22567C1@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.173.139 X-Source-L: No X-Exim-ID: 1sbnVF-004IhR-2N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.5]) [201.172.173.139]:48540 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 1 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNIq1DqX1Pth9GMdWrQUaHfPu81dM163CkyJvU3EYaVZU0ity3MH8lnRMPsIfvh2QpQj8FLBcf4ykY5s8/Qt6e31lGwYzGs4JYQ29Ge7YBKpnjsCv/KY YP8Nu6kx5v6aTo7LlDXREH26Eb/Tf8irlwC2QmjayvUN3Gn809+PLISnEaTTqVEho4LKtXYiPk36dk2LEh5EvwNR+6X3Z0k4gKWWkMnX6WbSUCE1QqtgvOJ0 >> @@ -48,7 +51,7 @@ struct glink_msg { >> struct glink_defer_cmd { >> struct list_head node; >> >> - struct glink_msg msg; >> + struct glink_msg_hdr msg; >> u8 data[]; >> }; > > Instead of this change (and the container_of() uses below), I think you > can just simply drop "data" here. I don't see anything using it except > the struct_size()s which can all change their "data" argument to > msg.data. e.g.: Whaa.. I'm sorry, I totally missed this response. I think I was traveling a lot back then. > > - dcmd = kzalloc(struct_size(dcmd, data, extra), GFP_ATOMIC); > + dcmd = kzalloc(struct_size(dcmd, msg.data, extra), GFP_ATOMIC); > > With those changed, I think this patch becomes more readable. Yes; I think I can change the code like this. :) Thanks! -- Gustavo