From: Jeffrey E Altman <jaltman@auristor.com>
To: "Gustavo A. R. Silva (gustavoars@kernel.org)"
<gustavoars@kernel.org>, David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] afs: Fix fall-through warnings for Clang
Date: Wed, 21 Apr 2021 19:03:47 -0400 [thread overview]
Message-ID: <45926d81-cfae-8465-84e6-af76d668c1ef@auristor.com> (raw)
In-Reply-To: <20210420211615.GA51432@embeddedor>
[-- Attachment #1.1.1: Type: text/plain, Size: 691 bytes --]
On 4/20/2021 5:16 PM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple fallthrough pseudo-keywords
> in places where the code is intended to fall through to the next
> case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
> - Place blank line after the fallthrough markings, not before.
> Link: https://lore.kernel.org/linux-hardening/748935.1606147853@warthog.procyon.org.uk/
This change looks good to me.
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
[-- Attachment #1.1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-04-21 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 21:16 [PATCH v2][next] afs: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-21 23:03 ` Jeffrey E Altman [this message]
2021-05-18 0:33 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45926d81-cfae-8465-84e6-af76d668c1ef@auristor.com \
--to=jaltman@auristor.com \
--cc=dhowells@redhat.com \
--cc=gustavoars@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox