From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by
Date: Wed, 19 Jun 2024 18:12:01 +0200 [thread overview]
Message-ID: <4c74c145-4fc1-44b9-88e7-1075c541adba@gmail.com> (raw)
In-Reply-To: <20240619144320.GA2091442@thelio-3990X>
On 19/06/2024 16:43, Nathan Chancellor wrote:
> On Wed, Jun 19, 2024 at 11:40:57AM +0200, Javier Carrasco wrote:
>> Use the __counted_by compiler attribute for the data[] flexible array member
>> to improve the results of array bound sanitizers.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>> ---
>> The size is assigned before the first reference to the flexible array
>> (see pkt_add()), which allows for a straightforward annotation without
>> further modifications.
>
> Agreed, this seems like a reasonable patch in and of itself that should
> work:
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> It might also make sense to change the pkt allocation to use
> struct_size() instead of open coding it?
Sure, it looks much better. I will send a v2 with the patch and the
corresponding Suggested-by:
Thanks and best regards,
Javier Carrasco
prev parent reply other threads:[~2024-06-19 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:40 [PATCH] USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by Javier Carrasco
2024-06-19 14:43 ` Nathan Chancellor
2024-06-19 15:27 ` Gustavo A. R. Silva
2024-06-19 16:12 ` Javier Carrasco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c74c145-4fc1-44b9-88e7-1075c541adba@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=johan@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).