From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928491C3BE2 for ; Sat, 26 Apr 2025 06:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745648896; cv=none; b=L0z52bFlSCZf3A2f/DAGqa0ldHKVp9wX3igT7zIQhxz+6nfxyI/VxW/NYuVDGwsPhxQWHGl5D3uxZIa/AzBoBq6m0kxL38Xt0BjZOcixhPoeljoRiFWBIx9/zuPrY8jLOx0ce7RC4R7AcE8wLNwy+lg/eTd1bRl3GtigBxbgibU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745648896; c=relaxed/simple; bh=iLSvSZrpExHs6iGtLUUAugyRIjzInghTCIhpfN7xuNY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IK0eh+S901XLftCoIcAnRRJ80F2prL01+djINBZiWDD1wZukwVEwBiZoy0zk5kGxZAl3G4Ukeb3Gadb0dsQjxTYB5j64zU9eAH8pouKUXpkrmhMkbfwXR7xNc+d0I3Zz2ihtsWIM5JPtAEbJqgI1FKkSd4QFo466FPzvjYOtDzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gyJgDvZC; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gyJgDvZC" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ac25520a289so468881266b.3 for ; Fri, 25 Apr 2025 23:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745648893; x=1746253693; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Xv4tKOaC/Hpdjay7QKa+hiaqSaXkzeRpeVA+weQIJVQ=; b=gyJgDvZCtR8keRLxkkzZHndM0aELTelygiaC95roeu/wgfQrOe3bi1Tr5M8gH3NGff 1kFebzSb2tmsZD44hMaeVJlHg48BvgS+u3zntUr6JoVjQMa9uuR5y+i600InH+8dB5YI i1G57fQ1dSu/BfCWH8JEgBKnj6ShTpmDHRq2k92zyA2eE21gPxIKEMOMfN1aP0I2O1hY ezfCnc6mYPesvMq6bTgy1mpSmhbrNZJxiCgbY2ey6S1vlEz2tbWB2ezG+1OSLrkL7sFn FqbEBSgtQb8/AmxDS2Yccv5lO+rJrpoV0oLMofc5jwQQiPEJYBdPu6+ImmCjMBtXKObZ vYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745648893; x=1746253693; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xv4tKOaC/Hpdjay7QKa+hiaqSaXkzeRpeVA+weQIJVQ=; b=aR5zViGuLtMtdVlZHeVkv3d43/8F4WrtWxSsMz/40g1Yp3JKRiXyMD9DZySVadYTor Z08R2YCldshSqbvpqJ0adbRqUN8Le76egBzDg3kTYdrqZ01J3XWwpaE3vK4NRf43NHpt O73toiLMGWMJjzcKMk1CuQy6ZeZ5ISx5IUKNyRR1YdMZ5Pr8PwK+jbiXmO/4zii6ZvzJ 2a6LQsZwjobMN/AknsctmFXTOYzai0m9ERjDKa6asca4NlzRcGzUaQtggPXeNoJ2U3ci 1m8AzwQBEfMS6DEdgRr38EKoQB7mXXDm17utjzFBtYxQzbpi3DddNfnH8wA1ZgeQb0ZN kSgA== X-Forwarded-Encrypted: i=1; AJvYcCVHFJtycOtK7nEmfs2wemoZYNtaMzsElsSzm8jkX1IImlvdKgCQfGBFjWfjJhCD7Tiu0rQcwenXcogip4ozDrI=@vger.kernel.org X-Gm-Message-State: AOJu0YxRxpA2xTf5WQkvXE3vHcfAZVB7BNTf8MA5W8vXa2lOu27N0BqA bp8cRzMYg9No6P9SQJb/WiLg8Z+RKORKKW8gj025P5BdsgPCP8P2JAiORMA7Smk= X-Gm-Gg: ASbGncuX6s7AYvTtJTY1OB3b47hGJe2DhIfSXYvlgdTBjeNEOu2gYF13kmMiG5qDR7k kXmyzdUNt0g1qxRGzm4LdphNOkhkotJftAIYSvoTyb6r5Yp1ny+qsGmr5d7iFWrH7yWaIOwopvv e5BTBfJotRnmn6RSqhtcePFl3yrhKmQPnsGRdE5jkgeaBGfEPK2E0x5cbj6dvRwTAwrdm6ctvoe 7i5Ds33qG3Br68UQ01xEa3nY1y5gLK/DKY3+l3bkggVEdkkYbJosp/+yJ2ncVl+RTohmlEBF0g1 6kzxK1A4Hl/5JWcZljcJcraivSEwoMldEUbcnaD3TG7RcOTAiE4v3vTA8xCTi3d5t7Y9 X-Google-Smtp-Source: AGHT+IESqmurfVzpwJY+LRtMTyy9+uS5Dp4QmJ2LQdrE9JHCD+tPlEB/tEuiwBzn7LlHhYd7RH99Aw== X-Received: by 2002:a17:907:9492:b0:acb:b9ab:6d6f with SMTP id a640c23a62f3a-ace713a19b6mr428854466b.38.1745648892392; Fri, 25 Apr 2025 23:28:12 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef1475ccsm4637134a91.44.2025.04.25.23.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 23:28:11 -0700 (PDT) Message-ID: <5671cd19-6026-4bfd-946a-daffdb899e1d@suse.com> Date: Sat, 26 Apr 2025 15:58:06 +0930 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: compression: Adjust cb->compressed_folios allocation type To: Kees Cook , Chris Mason Cc: Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250426062328.work.065-kees@kernel.org> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20250426062328.work.065-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2025/4/26 15:53, Kees Cook 写道: > In preparation for making the kmalloc family of allocators type aware, > we need to make sure that the returned type from the allocation matches > the type of the variable being assigned. (Before, the allocator would > always return "void *", which can be implicitly cast to any pointer type.) > > The assigned type is "struct folio **" but the returned type will be > "struct page **". These are the same allocation size (pointer size), but > the types don't match. Adjust the allocation type to match the assignment. > > Signed-off-by: Kees Cook Reviewed-by: Qu Wenruo Thanks, Qu > --- > Cc: Chris Mason > Cc: Josef Bacik > Cc: David Sterba > Cc: > --- > fs/btrfs/compression.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index e7f8ee5d48a4..7f11ef559be6 100644 > --- a/fs/btrfs/compression.c > +++ b/fs/btrfs/compression.c > @@ -606,7 +606,7 @@ void btrfs_submit_compressed_read(struct btrfs_bio *bbio) > free_extent_map(em); > > cb->nr_folios = DIV_ROUND_UP(compressed_len, PAGE_SIZE); > - cb->compressed_folios = kcalloc(cb->nr_folios, sizeof(struct page *), GFP_NOFS); > + cb->compressed_folios = kcalloc(cb->nr_folios, sizeof(struct folio *), GFP_NOFS); > if (!cb->compressed_folios) { > ret = BLK_STS_RESOURCE; > goto out_free_bio;