From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4426DC433B4 for ; Tue, 20 Apr 2021 20:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 038C4613E6 for ; Tue, 20 Apr 2021 20:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233724AbhDTUxZ (ORCPT ); Tue, 20 Apr 2021 16:53:25 -0400 Received: from gateway20.websitewelcome.com ([192.185.65.13]:30204 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233682AbhDTUxZ (ORCPT ); Tue, 20 Apr 2021 16:53:25 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 462E34012CE5D for ; Tue, 20 Apr 2021 15:17:48 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YwzIlH8yrL7DmYwzIlPDMR; Tue, 20 Apr 2021 15:28:48 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Xb9N7Jsx/GlDsx+8cy7TfYtbXj2e5xdFzA0RMDZFGS4=; b=vyRURm0PlfCotJhgp8bACFJrlx p5eb3bn+44IBTSTReooJji6rAKKYPmQPuR51wmZysPNMxshY5678nfL6NJraLJkbrNMM4p/W3/TI/ T7SrAGWqNMGxScqkAfDsI+HVNsUnfqQ1Y9+4uH+qwLuSi9CH6cqxogZFL67g4nwxWy2m66IFIkHo8 79c9ANn3tylDcuW4anbtrPkM6BBjiOM4gMPAmrCs7qDt2i3wEF/nJDXvxQudqnDkQggaxWqkqHPp/ rsjOHdAp3MtX7zdlVRaAcLtnPcnYeW1zPedY5mh5vWgP99T5yxGbLFwHemJ+izNFehc6bW/oVKpzj QAI0uc1A==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:49080 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lYwzG-003Adg-Cn; Tue, 20 Apr 2021 15:28:46 -0500 Subject: Re: [PATCH 006/141] gfs2: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" , Bob Peterson , Andreas Gruenbacher Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <84d07c8510abf95c9e656454961c09b14485b856.1605896059.git.gustavoars@kernel.org> From: "Gustavo A. R. Silva" Message-ID: <5adf738a-315b-a80e-46ff-06822441a789@embeddedor.com> Date: Tue, 20 Apr 2021 15:29:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <84d07c8510abf95c9e656454961c09b14485b856.1605896059.git.gustavoars@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lYwzG-003Adg-Cn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:49080 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 223 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:25, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple goto statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > fs/gfs2/inode.c | 2 ++ > fs/gfs2/recovery.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c > index 077ccb1b3ccc..9a85214c2505 100644 > --- a/fs/gfs2/inode.c > +++ b/fs/gfs2/inode.c > @@ -960,6 +960,7 @@ static int gfs2_link(struct dentry *old_dentry, struct inode *dir, > break; > case 0: > error = -EEXIST; > + goto out_gunlock; > default: > goto out_gunlock; > } > @@ -1500,6 +1501,7 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry, > break; > case 0: > error = -EEXIST; > + goto out_gunlock; > default: > goto out_gunlock; > } > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c26c68ebd29d..5b2a01d9c463 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -437,6 +437,7 @@ void gfs2_recover_func(struct work_struct *work) > case GLR_TRYFAILED: > fs_info(sdp, "jid=%u: Busy\n", jd->jd_jid); > error = 0; > + goto fail; > > default: > goto fail; >