From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: sgi_w1: Replace all non-returning strlcpy with strscpy
Date: Thu, 1 Jun 2023 19:03:54 +0200 [thread overview]
Message-ID: <6e2bbefc-b25a-e7c4-5a11-f5c2a1e1f8f0@linaro.org> (raw)
In-Reply-To: <20230523022023.2406955-1-azeemshaikh38@gmail.com>
On 23/05/2023 04:20, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
This was already fixed. Please work on linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git/commit/?h=for-next&id=5dfd3c73ff81618fee0ef682b6fd7779863f41e4
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-01 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 2:20 [PATCH] w1: sgi_w1: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 17:22 ` Kees Cook
2023-05-30 23:06 ` Kees Cook
2023-06-01 17:03 ` Krzysztof Kozlowski
2023-06-01 18:25 ` Kees Cook
2023-06-01 17:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2bbefc-b25a-e7c4-5a11-f5c2a1e1f8f0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=azeemshaikh38@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox