From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/6][next] cfg80211: Avoid clashing function prototypes
Date: Tue, 18 Oct 2022 14:31:12 -0500 [thread overview]
Message-ID: <71935a08-e9d3-5f9e-5b9a-7847bd38b756@embeddedor.com> (raw)
In-Reply-To: <202210171939.61FFBE79A7@keescook>
On 10/17/22 21:41, Kees Cook wrote:
>>
>> static const iw_handler orinoco_handler[] = {
>> IW_HANDLER(SIOCSIWCOMMIT, orinoco_ioctl_commit),
>> - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname),
>> + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname),
>
> This hunk should be in the orinoco patch, I think?
I just didn't want to have this huge patch touching multiple
different files. That's why I decided to split it up into three
separate patches.
But yeah; now it seems like a good idea to merge patches 1 to 3
into just a single patch.
>
>
>> [...]
>> + [IW_IOCTL_IDX(SIOCGIWRETRY)] = cfg80211_wext_giwretry,
>
> The common practice seems to be to use IW_HANDLER instead of open-coding
> it like this.
>
> IW_HANDLER(SIOCGIWRETRY, cfg80211_wext_giwretry),
Yeah; I forget this after reverting Sami's changes:
32fc4a9ad56f ("cfg80211: fix callback type mismatches in wext-compat")
I'll fix it up. :)
Thanks for the feedback!
--
Gustavo
next prev parent reply other threads:[~2022-10-18 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 20:32 [PATCH 0/6][next] Avoid clashing function prototypes Gustavo A. R. Silva
2022-10-17 20:33 ` [PATCH 1/6][next] orinoco: " Gustavo A. R. Silva
2022-10-18 2:26 ` Kees Cook
2022-10-17 20:34 ` [PATCH 2/6][next] cfg80211: " Gustavo A. R. Silva
2022-10-18 2:41 ` Kees Cook
2022-10-18 19:31 ` Gustavo A. R. Silva [this message]
2022-10-17 20:34 ` [PATCH 3/6][next] ipw2x00: Remove unnecessary cast to iw_handler in ipw_wx_handlers Gustavo A. R. Silva
2022-10-18 2:43 ` Kees Cook
2022-10-17 20:35 ` [PATCH 4/6][next] hostap: Avoid clashing function prototypes Gustavo A. R. Silva
2022-10-18 2:48 ` Kees Cook
2022-10-17 20:35 ` [PATCH 5/6][next] zd1201: " Gustavo A. R. Silva
2022-10-18 2:49 ` Kees Cook
2022-10-17 20:36 ` [PATCH 6/6][next] airo: " Gustavo A. R. Silva
2022-10-18 2:53 ` Kees Cook
2022-10-19 5:58 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71935a08-e9d3-5f9e-5b9a-7847bd38b756@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox