From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Julia Lawall <julia.lawall@inria.fr>, Kees Cook <keescook@chromium.org>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] comedi: Annotate struct comedi_lrange with __counted_by
Date: Sun, 1 Oct 2023 09:50:20 +0200 [thread overview]
Message-ID: <7e234efd-413c-ef6b-857b-d364db21141e@wanadoo.fr> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2310010922250.3166@hadrien>
Le 01/10/2023 à 09:25, Julia Lawall a écrit :
>
> This is not found due to the regular expression used for the name of the
> alloc function. Maybe you could drop it entirely? Maybe you could just
> check for alloc somewhere in the string?
That's how I found it.
I simplified a lot Kees's script and looked for function names that did
*not* match his regex.
Functions that:
- return a pointer to a struct
- are used with struct_size()
- store the value used to compite the size in another field of the
struct
are good enough candidates.
I think that removing the regex all together would be just good enough.
CJ
>
> identifier ALLOC =~ "alloc";
>
> works in this case.
>
> Also, I see in the link that you have:
>
> // Options: --all-includes
>
> You can actually force this by putting
>
> #spatch --all-includes
Nice, thanks for the tip.
>
> and any other options you want.
>
> julia
>
>
next prev parent reply other threads:[~2023-10-01 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 9:14 [PATCH] comedi: Annotate struct comedi_lrange with __counted_by Christophe JAILLET
2023-09-30 20:57 ` Kees Cook
2023-10-01 7:25 ` Julia Lawall
2023-10-01 7:50 ` Christophe JAILLET [this message]
2023-10-01 7:45 ` Julia Lawall
2023-10-01 15:26 ` Kees Cook
2023-10-01 19:14 ` Julia Lawall
2023-10-01 21:05 ` Kees Cook
2023-10-01 21:22 ` Kees Cook
2023-10-01 22:21 ` Kees Cook
2023-10-02 5:38 ` Julia Lawall
2023-10-02 7:36 ` Kees Cook
2023-11-05 21:27 ` Christophe JAILLET
2023-10-01 6:43 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e234efd-413c-ef6b-857b-d364db21141e@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=abbotti@mev.co.uk \
--cc=gustavoars@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox