From: Georgi Djakov <djakov@kernel.org>
To: Odelu Kukatla <quic_okukatla@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
cros-qcom-dts-watchers@chromium.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, quic_rlaggysh@quicinc.com,
quic_mdtipton@quicinc.com
Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration
Date: Tue, 25 Jun 2024 16:37:42 +0300 [thread overview]
Message-ID: <83ea0718-362a-47e1-a311-58c8b3ef39dc@kernel.org> (raw)
In-Reply-To: <20240607173927.26321-5-quic_okukatla@quicinc.com>
On 7.06.24 20:39, Odelu Kukatla wrote:
> Add clocks which need to be enbaled for configuring
> QoS on sc7280.
>
Nit: s/enbaled/enabled/
> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
In any case:
Acked-by: Georgi Djakov <djakov@kernel.org>
Bjorn, the dt-binding change is available in my icc-rpmh-qos branch
in case you want to make the dtbs checker happy when you apply this.
BR,
Georgi
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index ba43fba2c551..a3c640d394e9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2130,6 +2130,8 @@
> reg = <0 0x016e0000 0 0x1c080>;
> #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> + clocks = <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
> + <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>;
> };
>
> aggre2_noc: interconnect@1700000 {
> @@ -2137,6 +2139,7 @@
> compatible = "qcom,sc7280-aggre2-noc";
> #interconnect-cells = <2>;
> qcom,bcm-voters = <&apps_bcm_voter>;
> + clocks = <&rpmhcc RPMH_IPA_CLK>;
> };
>
> mmss_noc: interconnect@1740000 {
next prev parent reply other threads:[~2024-06-25 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 17:39 [PATCH v5 0/4] Add support for QoS configuration Odelu Kukatla
2024-06-07 17:39 ` [PATCH v5 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-06-18 14:47 ` Konrad Dybcio
2024-06-07 17:39 ` [PATCH v5 2/4] interconnect: qcom: sc7280: enable QoS configuration Odelu Kukatla
2024-06-18 14:46 ` Konrad Dybcio
2024-06-21 17:43 ` Odelu Kukatla
2024-07-01 16:42 ` Bjorn Andersson
2024-07-01 23:32 ` Georgi Djakov
2024-07-02 18:01 ` Odelu Kukatla
2024-06-07 17:39 ` [PATCH v5 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-06-13 16:28 ` Rob Herring (Arm)
2024-06-07 17:39 ` [PATCH v5 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
2024-06-18 14:47 ` Konrad Dybcio
2024-06-25 13:37 ` Georgi Djakov [this message]
2024-06-07 21:20 ` [PATCH v5 0/4] Add support for QoS configuration Dmitry Baryshkov
2024-06-26 4:30 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ea0718-362a-47e1-a311-58c8b3ef39dc@kernel.org \
--to=djakov@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).