Linux Hardening
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] net/packet: Fix fall-through warnings for Clang
Date: Tue, 20 Apr 2021 15:10:42 -0500	[thread overview]
Message-ID: <895bef99-a483-1d20-8b4c-2eea3c0d341f@embeddedor.com> (raw)
In-Reply-To: <20210305094429.GA140795@embeddedor>

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:44, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  net/packet/af_packet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> index e24b2841c643..880a1ab9a305 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -1652,6 +1652,7 @@ static int fanout_add(struct sock *sk, struct fanout_args *args)
>  	case PACKET_FANOUT_ROLLOVER:
>  		if (type_flags & PACKET_FANOUT_FLAG_ROLLOVER)
>  			return -EINVAL;
> +		break;
>  	case PACKET_FANOUT_HASH:
>  	case PACKET_FANOUT_LB:
>  	case PACKET_FANOUT_CPU:
> 

  reply	other threads:[~2021-04-20 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:44 [PATCH RESEND][next] net/packet: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:10 ` Gustavo A. R. Silva [this message]
2021-05-18  0:58   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=895bef99-a483-1d20-8b4c-2eea3c0d341f@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox