Linux Hardening
 help / color / mirror / Atom feed
From: "Greenman, Gregory" <gregory.greenman@intel.com>
To: "kvalo@kernel.org" <kvalo@kernel.org>,
	"keescook@chromium.org" <keescook@chromium.org>
Cc: "Golant, Michael" <michael.golant@intel.com>,
	"Goodstein, Mordechay" <mordechay.goodstein@intel.com>,
	"Coelho, Luciano" <luciano.coelho@intel.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Errera, Nathan" <nathan.errera@intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"Stern, Avraham" <avraham.stern@intel.com>,
	"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
	"Beker, Ayala" <ayala.beker@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Peer, Ilan" <ilan.peer@intel.com>,
	"Berg, Johannes" <johannes.berg@intel.com>
Subject: Re: [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly
Date: Wed, 28 Sep 2022 06:29:41 +0000	[thread overview]
Message-ID: <9019c8d467ed1d844d29d00b52604e74b330583f.camel@intel.com> (raw)
In-Reply-To: <874jwu4lc7.fsf@kernel.org>

On Mon, 2022-09-26 at 10:59 +0300, Kalle Valo wrote:
> Kees Cook <keescook@chromium.org> writes:
> 
> > In preparation for reducing the use of ksize(), explicitly track the
> > size of scan_cmd allocations. This also allows for noticing if the scan
> > size changes unexpectedly. Note that using ksize() was already incorrect
> > here, in the sense that ksize() would not match the actual allocation
> > size, which would trigger future run-time allocation bounds checking.
> > (In other words, memset() may know how large scan_cmd was allocated for,
> > but ksize() will return the upper bounds of the actually allocated memory,
> > causing a run-time warning about an overflow.)
> > 
> > Cc: Gregory Greenman <gregory.greenman@intel.com>
> > Cc: Kalle Valo <kvalo@kernel.org>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: Paolo Abeni <pabeni@redhat.com>
> > Cc: Luca Coelho <luciano.coelho@intel.com>
> > Cc: Johannes Berg <johannes.berg@intel.com>
> > Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> > Cc: Ilan Peer <ilan.peer@intel.com>
> > Cc: linux-wireless@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Gregory, can I take this directly to wireless-next?
> 

Acked-by: Gregory Greenman <gregory.greenman@intel.com>

Yes, thanks!

  reply	other threads:[~2022-09-28  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 22:08 [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly Kees Cook
2022-09-26  7:59 ` Kalle Valo
2022-09-28  6:29   ` Greenman, Gregory [this message]
2022-09-28  6:44 ` [v2] wifi: " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9019c8d467ed1d844d29d00b52604e74b330583f.camel@intel.com \
    --to=gregory.greenman@intel.com \
    --cc=avraham.stern@intel.com \
    --cc=ayala.beker@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=ilan.peer@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=michael.golant@intel.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=mordechay.goodstein@intel.com \
    --cc=nathan.errera@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox