From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Odelu Kukatla <quic_okukatla@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
cros-qcom-dts-watchers@chromium.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, quic_rlaggysh@quicinc.com,
quic_mdtipton@quicinc.com
Subject: Re: [PATCH v4 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280
Date: Wed, 27 Mar 2024 13:14:27 +0100 [thread overview]
Message-ID: <99bda06f-8e2f-4f51-88f2-d99187e29b92@linaro.org> (raw)
In-Reply-To: <e95634ba-b186-4fee-b93b-1ac4662fd2c4@quicinc.com>
On 27/03/2024 12:35, Odelu Kukatla wrote:
>>> maxItems: 1
>>>
>>> + clocks:
>>> + minItems: 1
>>> + maxItems: 2
>>
>> Why is this flexible? Nothing in commit msg explains that. I gave the
>> same talk twice, gave there examples, yet it is not enough...
>>
>
> Clocks property is optional, and can be either 1 or 2 or none.
> I think "minItems: 1" should be removed. If no clock property is mentioned in node that means no clock is required to be enabled for QoS configuration.
>
> I will add back specific number of clocks based on interconnect compatible similar to what i did in v3.
Just be sure you read the example I gave you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-27 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 18:16 [PATCH v4 0/4] Add support for QoS configuration Odelu Kukatla
2024-03-25 18:16 ` [PATCH v4 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-03-26 20:56 ` Konrad Dybcio
2024-03-27 8:44 ` Krzysztof Kozlowski
2024-03-27 11:42 ` Odelu Kukatla
2024-04-03 8:45 ` Odelu Kukatla
2024-04-13 19:31 ` Konrad Dybcio
2024-05-08 2:37 ` Mike Tipton
2024-05-28 14:52 ` Odelu Kukatla
2024-06-18 14:26 ` Konrad Dybcio
2024-03-25 18:16 ` [PATCH v4 2/4] interconnect: qcom: sc7280: enable QoS programming Odelu Kukatla
2024-03-25 18:16 ` [PATCH v4 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-03-26 7:30 ` Krzysztof Kozlowski
2024-03-27 11:35 ` Odelu Kukatla
2024-03-27 12:14 ` Krzysztof Kozlowski [this message]
2024-03-25 18:16 ` [PATCH v4 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99bda06f-8e2f-4f51-88f2-d99187e29b92@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).