From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35563E00B4 for ; Tue, 7 Jul 2026 10:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783419925; cv=none; b=tazngy5mh4iyd3EQ6fkUwn229s3d7PfMUxZD4WmQMp/sDETOtXZAsWp2KSovZCAVYNuSYqn60eYdikhYX06LcPKz8T6izTCE4bo/CkTCfg82qxwP1X013KdcjlgX0GNl8ItV9uKEVenqGm0RkrmxEMrUEcpmIDtXjgG463EbnHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783419925; c=relaxed/simple; bh=9FaByEYQ1+f7toZfhp8ANfaJcWrdVoKguDXFfomYHnU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GxvuD+Hyt3yFCKCQuZwhj1DxOlDEPn2iaOsxyNrGEUlQA3LcceoD2j+/2uK8y6sAWEirFvJqsbzzEAcy58GTt8jRajChNUT2eyfcdvveBlfzj+I/M/yaAn90v0Pne+aarlxuhP0XeSSIcAKg+hutIGBnfqJAOsDXG/0ufKiAnmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=illqUTys; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C2txeiaZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="illqUTys"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C2txeiaZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6678DkcR3138639 for ; Tue, 7 Jul 2026 10:25:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XP5y6yGHt3Ajgb88Dol1E8KHAvk0yQ+E6gY+cGfJFsU=; b=illqUTys1FEjtQ2r JJiO83qoOAGwu4d2azr51/L4o3C7r8f/xXVuJyNxm+Bdk9qwucmgiqpd8hz7Dzgu ozJWczUxVBhw1HlLltKhXOWx2DQEMUCyhO+x7vZ42c5v7nzidw3z4dlgUNCQsYRV dLyrz4M5Qdun6buzr/xoMvKPOuzcJQ4HpRXNbOvhRKnxxVV73S+WQtNiy4pUQk9U UbbMNHxXorVebnIbf++hcPbluekhyhHQ5E4SH4YQyNtqxpWnQ1XIPbdbCyA1L3yk HxwoOo2xVuf+IbRGW+exPm+ZaCm2UVsWFEtwPeT1fbCTbZricKqstwjD4IJ70/gb GQrcPA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8t159fnu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 10:25:22 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccbb61893fso13898185ad.0 for ; Tue, 07 Jul 2026 03:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783419921; x=1784024721; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XP5y6yGHt3Ajgb88Dol1E8KHAvk0yQ+E6gY+cGfJFsU=; b=C2txeiaZgravPS2fywlur9+W7Uh66Ui8SaHcp5R1OM80RHbOgcdG5brheiBGGKaqDY Y2glyF8HgrOCBS84zHJRldUmkQ/XagXwGBQ8ZiI6McAIrAa7+KRUJkhbnqj8U6Os9IWS B/STy/75rTNd3j11u3nw4Jt1GHGP+CqrsROvoS3RwxLG+1e/zDaQfajUindx6WTRFOfe nA+PZNi9GV7GoEEPJsMsL1L8ACs4k2OO/s2O9+EVrraNZ80oPauLYKUFRsEnziK4Zx5O w9sMYhxFHpb940CaXu13XEaEocNNQ3jzg4MJJx7OBcrqUQK0RZSFZBZ8AZ5AqlfBjdHS zMzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783419921; x=1784024721; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XP5y6yGHt3Ajgb88Dol1E8KHAvk0yQ+E6gY+cGfJFsU=; b=Mn7xklXUyLLIwNhb3+YY/QV5u+2XVy2t1qt5sxe+FiIGjwKXuXqv+1+dePTkx9nuxd NRBkgnAK9ejgfT5t63Dcr5ZhPDFIRXrU+jA3+xmzTteuz6GT3HcW8ZzCEc/5Qn4H7nEt iAuZen2MsudFQYGnl8S//YW/5DOMCJHoA3irKCRhVXKnqOE1r9BTR5nDuJ+4V4ZMaJgI 89kfzDq0YR18F288stte2y4a3IEq61vO9viYMeYNjnzYcQ/2N448chTv3tyTU9kHNRbN vQULiAsviqcY9KXHVtYI7bigIzcWyvFchTGmPuicvNZ0r/QibmQUlDrTgv9KPeCO1Luf CmkQ== X-Forwarded-Encrypted: i=1; AHgh+RrRU1GLvH+oxHYX6u7GizMljrullNM3qc/4eTdugqCU8p4MCcUjbcBRblGD/Q/JHzM6SXMoyrEEKmNU9gY+eqE=@vger.kernel.org X-Gm-Message-State: AOJu0YxAvL6d3C30fGSvYiqGmveH2hDO2HyTVxxY0+dL7PF3M5b4xpXJ 2OGgIXegBvAIeme+WVrAKFKw/4XL8+mUkpWGnFPK4CyvH3mSK6sKoL6cp47Q/sPKWvKqe+8o6F5 g5PccrABXhtDLcE8NLc99sGK+SV0jIE3IfUB7uLKOz2O7y0rZioxvQx/vHZK+I6WNsiEaxeA= X-Gm-Gg: AfdE7cm4U9kb4/ySuw8nbAYOX5OaigVba69MwdMT5BJDEUJsGF90A3ld4uwkKdN3Ea0 UHfsOzMwt1aNZnQhuwHKVe1TYMbomo1SRKWWlkFzoyaMm1P2u7VZQtWakA+WkAL9+LqocFcALY9 7n1zBm4s1Jkv95oYJTv9stdNGCNd+KPBCdSyhu0Tvwy05oZz5s3ATtv6OndGaRpxx2VhA6eI6ea AbIDwBe3+DPJw3UAXvpYhGSylNhGZ0a9qRppt7n7VnnB/PArtQlca0saPGnE63NHql7J08ZfVum kUMrSj6FxmU0ldGt1W3Mkr588wWdEbNNWp31dWTjaQQzn6WLiB0r7Gn7ODWjLO6SwqqNGqloZ4k /g+mnhhGMwOVOSi/P0odV274g3UO+M4MtY8KG9+GGew== X-Received: by 2002:a17:902:f60e:b0:2c8:25c8:85a6 with SMTP id d9443c01a7336-2ccbe4004demr49315205ad.2.1783419921199; Tue, 07 Jul 2026 03:25:21 -0700 (PDT) X-Received: by 2002:a17:902:f60e:b0:2c8:25c8:85a6 with SMTP id d9443c01a7336-2ccbe4004demr49314885ad.2.1783419920605; Tue, 07 Jul 2026 03:25:20 -0700 (PDT) Received: from [10.217.199.117] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9bdb9bbsm9319265ad.4.2026.07.07.03.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 03:25:20 -0700 (PDT) Message-ID: <9dc4b29e-e9fb-421a-b789-eb16a68ff915@oss.qualcomm.com> Date: Tue, 7 Jul 2026 15:55:13 +0530 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants To: Dmitry Baryshkov , Daniel Lezcano Cc: Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com> <20260703-qmi-tmd-v4-1-3882189c1f83@oss.qualcomm.com> <977711ef-c1fb-4735-b82a-4ca2f4797f51@oss.qualcomm.com> <8ad14017-bce7-485e-9677-9cbf8ecb2742@oss.qualcomm.com> <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> <1aca8d60-8e39-4532-9095-a5260bba76ac@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: nblUwcbHNSdfxFeOmYL2IVR83xF0cloj X-Authority-Analysis: v=2.4 cv=HstG3UTS c=1 sm=1 tr=0 ts=6a4cd412 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=fbyXy8itprBkbsvVMWwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: nblUwcbHNSdfxFeOmYL2IVR83xF0cloj X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEwMCBTYWx0ZWRfXzYt8ib6ZKcqg YA7UpFfM4oMz9qD34pFiytooc4RDv3jXumml++YpeBDVBrg665YqUSJJlFcwbITQy817Os85/mg er8cC7fgUzkdu/L+GvwK/qYKPnaX0vY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEwMCBTYWx0ZWRfXys3iyz3tRIBa D6nUsY7JWqAyvnrS9E8JLNnjep8nhJrs6phR7trOfRRP85FunvUd4M4LNn/ZyLVKuqIW93L/7Rz a2Zr7+UckmWV4ZvLDOE207ACJujCXwPSZa2Bg9LKhxkOJSBrqIaSyi/EdCwixYSxLpXYtB9ggiv WPOovz1iQ3OLGTf2pMCDprQiE6c507P26s1v4ax1UvpuTopBdEKoqY9ZTC/pDj71OBvU3wSFJqv ICIWgx0WHsO82d6mcRAmMjMd27TA9bggVewzczTe04/hdHM2MSuAVFYPReJLi2WFbRO3yWYYtzp hOONWfZn+3KbALU0lEfXiEdMYiDyzsFbrkOwx13+LCkMx8+V+4+HDjsK9O16H1a6OZC6NIkFIp6 y2d39sYlmJonjv2/U3uuYqXkSWF9grrDPgiSKLFbrDJ1ivTie3Z26MVVdSM/Bwwbld++twn4j3K GIKaEvOKot78EXQX6kA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070100 On 7/7/2026 1:04 AM, Dmitry Baryshkov wrote: > On Mon, Jul 06, 2026 at 08:11:35PM +0200, Daniel Lezcano wrote: >> On 7/6/26 19:47, Dmitry Baryshkov wrote: >>> On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: >>>> On 7/3/26 17:42, Dmitry Baryshkov wrote: >>>>> On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: >>>>>> >>>>>> >>>>>> On 7/3/2026 1:23 PM, Konrad Dybcio wrote: >>>>>>> On 7/3/26 7:03 AM, Gaurav Kohli wrote: >>>>>>>> Add Device Tree binding constants for Qualcomm Thermal Mitigation >>>>>>>> Device (TMD) types used by remoteproc-backed thermal cooling devices. >>>>>>>> >>>>>>>> Qualcomm remote processors expose thermal mitigation endpoints >>>>>>>> through QMI. These endpoints can be registered with the thermal >>>>>>>> framework via the `#cooling-cells` property on the remoteproc node. >>>>>>>> >>>>>>>> The QMI TMD protocol identifies devices using string names (for example, >>>>>>>> "pa", "modem", and "cdsp_sw"), while the DT cooling-device binding with >>>>>>>> `#cooling-cells = <3>` requires numeric device id in the form: >>>>>>>> >>>>>>>> <&phandle device_id min_state max_state> >>>>>>>> >>>>>>>> Define common TMD device index constants shared across currently >>>>>>>> supported platforms. If a future target requires a different mapping, >>>>>>>> additional target-specific constants can be introduced while preserving >>>>>>>> existing DT ABI. >>>>>>>> >>>>>>>> Signed-off-by: Gaurav Kohli >> >> [ ... ] >> >>>>> Why are you using only those TMD devices? >>>>> >>>>>> More constants can be added as needed. >>>>> >>>>> Kodiak is one of the supported platforms. >>>> >>>> What would be the benefit of having more than thirteen cooling devices >>>> declared in the thermal framework and having only a couple of them mapped in >>>> a thermal zone ? >>>> >>>> I agree there are more TMDs but if they are unused for the moment, why do we >>>> need to add them ? Can we do that incrementally ? >>> >>> That's what I am trying to understand: why the implementation uses only >>> the selected two devices, if the modem on Kodiak supports others. How >>> can we find out, which TMDs to use on other devices. >> >> My understanding is that is an initial thermal setup. Gaurav will add them >> step by step while setting up all the thermal zones instead of sending a big >> patchset. And TBH, that will be much easier to review. > > In such a case it should be noted in the commit message and/or cover > letter. Thanks for the review/guidance. Not all TMD endpoints are relevant for kernel thermal zone binding — some like BCL and cold temperature are handled from userspace when needed. The constants here cover only what is needed for modem and CDSP thermal zones on the currently posted targets. Will add a note in the cover letter clarifying for current tmd's. Please let me if this is fine. > >