From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E52C433F5 for ; Wed, 18 May 2022 23:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbiERXAj (ORCPT ); Wed, 18 May 2022 19:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbiERXAb (ORCPT ); Wed, 18 May 2022 19:00:31 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42392375DF for ; Wed, 18 May 2022 15:59:04 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id z15-20020a9d65cf000000b00605f064482cso2399968oth.6 for ; Wed, 18 May 2022 15:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kygPfhyErW7dvKH17CTT82TgIAgiLDQSd48duVgDxwo=; b=O+ofcjZ731KvhGfJgQg10ps3UVFNc6LwD7fN9G3r2I0CQAE3XPw6a11H//xfRSdxMm 66tzSgCDJFgHSJGAf7O7bPtOVatqDLOsVQSAtuX7kalYG3WQ60yI1pdJ5HD/ZL1EYoZX KnnLxumJcG4Y1voi72hkujqfGvIpVkEwo2KRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kygPfhyErW7dvKH17CTT82TgIAgiLDQSd48duVgDxwo=; b=LkZhHEJIoNSTPlhqQK+Nusw4A8zNfmMu5Pkm34FXZb0hgDdbVGGFEjfBfSWj5Ql/nV XTYYiZLbN9HTh4bcU7bWYdeYYTaPUB9IoAYIN2R6NK1tRJiga53UgzOFjRXjpgoNbl8D 7/zqB+ISfpYkwL7ppDQLf/sHAIFuNkpl8M3R6PAOs8rB+lji3Fv25j1rygytASzBR+T5 Wqxujook2nW7daUpFLDQZC0HnvU5BG6kcaqLxcRKTO3uXm/Xz2e77iVkAwUxktmQxN16 VGzYRn99SmpEA3PmjUblg1r6ECdb3L19xQIH0Hbbv/FV9Utg/iNbpqcIgkBX79FViwCI YymA== X-Gm-Message-State: AOAM532awGTbUeK1GiqXILe31REE9ANenG4IA1SSbKKmfC0uN9n/LkQ3 knXQlOMAjGbqfZLg5bXEmY8M7w== X-Google-Smtp-Source: ABdhPJzcao+B0GJgFE10anN4Ws1SW5llNsEaaFkNV2yF+gALlyuED9RalqIh/OVY9Ws71U5cIpeNyA== X-Received: by 2002:a9d:34b:0:b0:605:f0f1:e28e with SMTP id 69-20020a9d034b000000b00605f0f1e28emr835845otv.304.1652914743981; Wed, 18 May 2022 15:59:03 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id d188-20020acab4c5000000b00325f4f40f9esm1274522oif.22.2022.05.18.15.59.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 15:59:03 -0700 (PDT) Subject: Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3 To: Kees Cook , David Howells Cc: David Woodhouse , Eric Biggers , Salvatore Bonaccorso , keyrings@vger.kernel.org, Adam Langley , Lee Jones , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Shuah Khan References: <20220518215129.264872-1-keescook@chromium.org> From: Shuah Khan Message-ID: <9e9a687e-3c72-fdf9-eb64-6be7b60b9706@linuxfoundation.org> Date: Wed, 18 May 2022 16:59:02 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220518215129.264872-1-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On 5/18/22 3:51 PM, Kees Cook wrote: > OpenSSL's ENGINE API is deprecated in OpenSSL v3.0, along with some > other functions. Remove the ENGINE use and a macro work-around for > ERR_get_error_line(). > > Cc: David Howells > Cc: David Woodhouse > Cc: Eric Biggers > Cc: Shuah Khan > Cc: Salvatore Bonaccorso > Cc: keyrings@vger.kernel.org > Suggested-by: Adam Langley > Co-developed-by: Lee Jones > Signed-off-by: Lee Jones > Signed-off-by: Kees Cook > --- > v1: https://lore.kernel.org/lkml/20211005161833.1522737-1-lee.jones@linaro.org/ > v2: https://lore.kernel.org/lkml/Yicwb+Ceiu8JjVIS@google.com/ > v3: > - Eliminate all the build warnings with OpenSSL 3 > - Fully remove ENGINE usage, if it can be optional, just drop it. > --- > scripts/sign-file.c | 49 ++++++++++----------------------------------- > 1 file changed, 11 insertions(+), 38 deletions(-) Worked for me on OpenSSL v3 and older version . Tested-by: Shuah Khan thanks, -- Shuah