From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 894DD13F43A for ; Wed, 5 Mar 2025 02:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741143592; cv=none; b=bX+fT8JwFK+uExRcJISppb6QiYGtsxn3gjniCFuynbtfcPk2OSTGp+e9NswWNoJ8l9ZFRNWIT4WKNaVo0uETPgmZnpwfV6botlbjTHGRah4Y6pexHdYIc0v/aFHQynxJni+aJzebr6vgkMK9udMXE2tCI8JF1zqB6rhkgIUmm+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741143592; c=relaxed/simple; bh=PCNzOrZ6fFHbZFlpkP/J9R0cTPAHndmjskgnEeXZdu0=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=uuvHk1OdHSV6gNYnyHvAAMwHZUuOodEf6Bgoh/3JmJVq2PULV9lk5p0o8XVC+IX9s7/jNTD21UHs4ldU2gCl08hnesvZsXsMEKfwNM7qiluArwOiYg24lodjJZqv2UmI849UiHXpVKtevScp4cBONdo8eAmSYrybvtgHi7cXPi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qHAlah7c; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qHAlah7c" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741143577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TZUD9FHcJZMRi3hr6Ln+x8h4/Fn+HQN5iiqIcRwcYIk=; b=qHAlah7c6HYkboSWz6seWxBu15uRDhQ/OHZkb82vNp7rN6n51Himjf/ZmWCZg8ES+Nqqvf NBqk+9wLogJtBpRzkuH66vlwpHA60/rgf9Kk6SBEwBKQv7Miwf0+Q8mNxmunSIzu7YtLrZ HHE0cZKOfHqJbKIOGYiqtUYGrDDlDAk= Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: [PATCH] xfs: Replace deprecated strncpy() with strscpy() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <20250305022153.GC2803771@frogsfrogsfrogs> Date: Wed, 5 Mar 2025 03:59:24 +0100 Cc: Carlos Maiolino , linux-hardening@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20250305011020.160220-2-thorsten.blum@linux.dev> <20250305022153.GC2803771@frogsfrogsfrogs> To: "Darrick J. Wong" X-Migadu-Flow: FLOW_OUT On 5. Mar 2025, at 03:21, Darrick J. Wong wrote: > On Wed, Mar 05, 2025 at 02:10:21AM +0100, Thorsten Blum wrote: >> strncpy() is deprecated for NUL-terminated destination buffers. Use >> strscpy() instead and remove the manual NUL-termination. >> >> No functional changes intended. >> >> Link: https://github.com/KSPP/linux/issues/90 >> Cc: linux-hardening@vger.kernel.org >> Signed-off-by: Thorsten Blum >> --- > > Please read the list archives before you post: > https://lore.kernel.org/linux-xfs/20230211050641.GA2118932@ceph-admin/ My bad, I found [1] and saw that you reviewed it, but missed Li's reply. [1] https://lore.kernel.org/linux-kernel/Y9sKXhxvf0DDusih@magnolia/ [2] https://lore.kernel.org/linux-xfs/20230211050641.GA2118932@ceph-admin/