[PATCH] pstore/ram: Validate ECC parameters against Reed-Solomon constraint

[PATCH] pstore/ram: Validate ECC parameters against Reed-Solomon constraint

[Naoya Tezuka]

The Reed-Solomon library enforces the constraint `n <= 2^m - 1` via a
BUG_ON(), where `n` is `block_size + ecc_size` and `m` is `symsize` for
the pstore RAM backend. A driver providing invalid parameters can trigger
this, leading to a kernel panic. For more details on the theory behind:
https://www.cs.cmu.edu/~guyb/realworld/reedsolomon/reed_solomon_codes.html

This issue was discovered during develop chromeos_pstore driver:
https://lore.kernel.org/lkml/20250610050458.4014083-1-naoyatezuka@chromium.org/

Add a check to validate this constraint before initializing Reed-Solomon
codec. On failure, return -EINVAL to prevent the panic.

Signed-off-by: Naoya Tezuka <naoyatezuka@chromium.org>
---
 fs/pstore/ram_core.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index f1848cdd6d34..c7a2ff9c5a6c 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -212,6 +212,14 @@ static int persistent_ram_init_ecc(struct persistent_ram_zone *prz,
 		return -EINVAL;
 	}
 
+	if (prz->ecc_info.block_size + prz->ecc_info.ecc_size >
+	    (1 << prz->ecc_info.symsize) - 1) {
+		pr_err("%s: invalid ecc parameters (block_size = %d, ecc_size = %d, symsize = %d\n",
+		       __func__, prz->ecc_info.block_size,
+		       prz->ecc_info.ecc_size, prz->ecc_info.symsize);
+		return -EINVAL;
+	}
+
 	prz->buffer_size -= ecc_total;
 	prz->par_buffer = buffer->data + prz->buffer_size;
 	prz->par_header = prz->par_buffer +
-- 
2.50.0.rc2.701.gf1e915cc24-goog

Re: [PATCH] pstore/ram: Validate ECC parameters against Reed-Solomon constraint

[Tzung-Bi Shih]

On Fri, Jun 20, 2025 at 02:47:57PM +0900, Naoya Tezuka wrote:
> The Reed-Solomon library enforces the constraint `n <= 2^m - 1` via a
> BUG_ON(), where `n` is `block_size + ecc_size` and `m` is `symsize` for
  ^^^^^^^^
Better to provide a link, e.g. [1].

[1]: https://elixir.bootlin.com/linux/v6.15/source/lib/reed_solomon/decode_rs.c#L43

> the pstore RAM backend. A driver providing invalid parameters can trigger
> this, leading to a kernel panic. For more details on the theory behind:
> https://www.cs.cmu.edu/~guyb/realworld/reedsolomon/reed_solomon_codes.html
> 
> This issue was discovered during develop chromeos_pstore driver:

s/develop/developing/.

> https://lore.kernel.org/lkml/20250610050458.4014083-1-naoyatezuka@chromium.org/
> 
> Add a check to validate this constraint before initializing Reed-Solomon
> codec. On failure, return -EINVAL to prevent the panic.
> 
> Signed-off-by: Naoya Tezuka <naoyatezuka@chromium.org>

The patch makes sense to me:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

Re: [PATCH] pstore/ram: Validate ECC parameters against Reed-Solomon constraint

[Naoya Tezuka]

Hi Tzung-Bi and others,

I truly appreciate your time and feedback on my patch.

On Mon, Jun 23, 2025 at 12:03 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Fri, Jun 20, 2025 at 02:47:57PM +0900, Naoya Tezuka wrote:
> > The Reed-Solomon library enforces the constraint `n <= 2^m - 1` via a
> > BUG_ON(), where `n` is `block_size + ecc_size` and `m` is `symsize` for
>   ^^^^^^^^
> Better to provide a link, e.g. [1].
>
> [1]: https://elixir.bootlin.com/linux/v6.15/source/lib/reed_solomon/decode_rs.c#L43

You're right, I'll add that link to this `BUG_ON()` in the v2 patch.

>
> > the pstore RAM backend. A driver providing invalid parameters can trigger
> > this, leading to a kernel panic. For more details on the theory behind:
> > https://www.cs.cmu.edu/~guyb/realworld/reedsolomon/reed_solomon_codes.html
> >
> > This issue was discovered during develop chromeos_pstore driver:
>
> s/develop/developing/.

Thank you for pointing this out. I'll fix the typo in the v2 patch.

Best regards,
Naoya Tezuka