From: Thorsten Blum <thorsten.blum@linux.dev>
To: Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [RESEND PATCH v2] params: Annotate struct module_param_attrs with __counted_by()
Date: Tue, 4 Feb 2025 17:44:55 +0100 [thread overview]
Message-ID: <CBE23F82-A597-4DC5-A297-26F8DEFA07B0@linux.dev> (raw)
In-Reply-To: <20250114214956.915982-2-thorsten.blum@linux.dev>
On 14. Jan 2025, at 22:49, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> attrs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Increment num before adding a new param_attribute to the attrs array and
> adjust the array index accordingly. Increment num immediately after the
> first reallocation such that the reallocation for the NULL terminator
> only needs to add 1 (instead of 2) to mk->mp->num.
>
> Use struct_size() instead of manually calculating the size for the
> reallocation.
>
> Use krealloc_array() for the additional NULL terminator.
Hi, could someone please take another look at this?
It was already applied to modules-next in August 2024, but dropped
shortly after because of a Clang issue:
https://lore.kernel.org/all/20241029140036.577804-1-kernel@jfarr.cc
The Clang issue has been fixed for a while and this patch could be
applied again.
Thanks,
Thorsten
next prev parent reply other threads:[~2025-02-04 16:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 21:49 [RESEND PATCH v2] params: Annotate struct module_param_attrs with __counted_by() Thorsten Blum
2025-02-04 16:44 ` Thorsten Blum [this message]
2025-02-11 13:18 ` Thorsten Blum
2025-02-13 21:51 ` Luis Chamberlain
-- strict thread matches above, loose matches on Subject: below --
2025-02-13 22:13 Thorsten Blum
2025-02-13 22:21 ` Luis Chamberlain
2025-02-17 10:04 ` Petr Pavlu
2025-01-07 10:55 Thorsten Blum
2024-12-21 9:48 Thorsten Blum
2024-09-09 16:27 Thorsten Blum
2024-09-11 17:59 ` Luis Chamberlain
2024-09-13 16:46 ` Nathan Chancellor
2024-09-13 16:55 ` Luis Chamberlain
2024-09-13 18:40 ` Andy Shevchenko
2024-09-13 19:03 ` Thorsten Blum
2024-09-13 19:09 ` Andy Shevchenko
2024-09-13 19:12 ` Andy Shevchenko
2024-09-13 23:32 ` Thorsten Blum
2024-09-13 23:44 ` Nathan Chancellor
2024-09-14 0:23 ` Thorsten Blum
2024-09-16 9:45 ` Bill Wendling
2024-09-17 11:43 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBE23F82-A597-4DC5-A297-26F8DEFA07B0@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox