From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794948008; b=WnXyln8HEzPv4SuENMvbZzZkbSs7HqiTgVGcpAgij0Ux5Sb3/1OQXWas6F8bFPw+AT72 x4ZJvhRDDmO9NnazWO6H4917vvfJRavzHeefNUwkSAtZiUsqx+PkfgCwIrAWloub7g+LW rPmHGNxSo9B/mqau6r7lScCPyM9j6EtcFgBtlEm1z4WVgBDgsJvYGZ07kx4A64GX/ImoF Dw7ltVDCxfeuXtcXg0wojpZvZFzfNLJVCYEDFsPyUiFEnJWollCwXYFILmX/ycTh1bESt bNKjY/ct01jSZBGG2JJuNKoGtw7pg6AGQ+gOjaU16LgOOdC/VZeFlDcsBrnDTVrdcHg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794948008; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Transfer-Encoding:Content-Type:Date:Message-Id: From:To:Cc:Subject:X-Mailer:References:In-Reply-To; bh=+zkjXBeMkEDc7QufXqaSGB6NEDq0WBn2vnhWa4XM0nU=; b=OOXLlBVCkm+EFNK+8p7j84bfbrDWJOUlh91opi/YZjhL5RZ6KIcNvCvUcLvckxbM6DJR eIGNsjpAF8/7SI/HihtQJOl6P1HGO9HnxRwkf6LYnLaXffgZc9veAs10LQaRz0WtWQJBQ hHI66XxgKRur1VSo/L8xr4I4lfRRQsQuCkeZsZINl6+Oy+2I2yTQn6Z3mWRq3U9Yc9Pmm pHQEjg9uvIXr3b3lod8p7xvmei6HMGfJtk9fmVebWkodV/npLjISOueRMR+BPmqE5loG2 nRTy7zsEf/nhMfN9ENcjKfg51DcZOGddZlqusVC/d/o2X2BznYA8Fhj1LZhd8mpqSzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=wQiTHEmc; arc=none smtp.remote-ip=209.85.219.53 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 608A1606A31C for ; Tue, 17 Nov 2026 20:40:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 608A1606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=wQiTHEmc Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-92106d5371dso1474626d6.1 for ; Tue, 17 Nov 2026 12:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794948007; x=1795552807; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=+zkjXBeMkEDc7QufXqaSGB6NEDq0WBn2vnhWa4XM0nU=; b=wQiTHEmcLJ1w5dl8W2ZrpxnxgBRRFkilfGpWObOByVV4ZYPw/L+jCRd1Scet6nixi/ YeuzcfJncBd63FE+zpAuuNmoyZKqAb65YnbzZMsWF/qZ4QNZvRpkwhDzXo8Tx0BaUefL e7fKeoW+QD8YekVedo20sv8Qve0pX2hmS+p9KBznLxnZXk/Oco2p06XjUYBVeTelSg92 lWIeUbfDatuFMCbU40OQKvqQLmnN47Md6n+LyaRYhZUEYj0JjmKo6o394rvpJ5XUqNmC vk5KDIcarGarUX9DogDTjL+kNjq18fEh+H/j16Xtr5IIQKDf1Hnry0JHY5tKID/GOIkW xzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794948007; x=1795552807; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+zkjXBeMkEDc7QufXqaSGB6NEDq0WBn2vnhWa4XM0nU=; b=vuRF5Co2x2Ply0+sNEKmisrHB3LM4lIwk3h9GEqUMf5hJ/9wMe+nfCckdcpeafd8sQ lT4B7Q7zOPOleEyfbOPM6Tcw5ZTU8JAWnfrl0zcxsK3yfwUryTc0MirWt13MiecZJ9hn RRzZ9U2619RLZz0tmHV/9KXOoKuNyGlfZUvWshj4vc1/f8DtIzDIPqlBf8xSUVBbVpkI Qfubk7UQVYslPo+5eYldnuNr2bRNNyc6rCLfXvkvQLaMFS66XlWepOKwrAZhGfilTZWJ bhmti3sgUC2lKdGgwP1QRNYUPouLmMWetosrkzZKMNltJrjlqh711pMH/5/3HA1SbTxx abkg== X-Forwarded-Encrypted: i=1; AL+hErEcufKP7xP0eYPCauzx12JZKgzAh4/+tM1qWUbotQeTdc48tGLciSPWRYoCODfHGKNRRWo+on0/PA+trNUoS7k=@vger.kernel.org X-Gm-Message-State: APuU4Z/cyjVui37WJvs2ibASC5fEVyphSoOvVfyWsWxfPxjsCl3tx9CR lafT81CqmKiJMDcS3eETyx3rT2JmTAVfUcICBag1/gE1fpOGBC8Hv1i4 X-Gm-Gg: AZFdTZezSIG0YrtWr1jkZDF0QrlPGrqlV1d1HvJxYpPPQsAt01SpBS5nPHZVRwLy6K/ dO3L8HrHQ/iVto4435SMc2FECmxCItgXXafWAIJfu+b86dZEWHjxch47cEMLg2mw5vyu1q7sFmj JuIu39kyShYrvC5k+cwmZu4JzyUyygwEKC2JR8+vHJhbNKjStqsw64nxctDXAI8oilr+Yq0CRdG 6kHv5niJP43Zr+zfh4nDhcysw9MKIxEs00CTaRiF+HWPPDeF7ajdHM2S6FX2qNbqnTu/irP/vy7 TzWNy9qCeLL6Ow/UmwoiOqooDfBV4oc4ZnO96jCrpeMOQh+OyucIYI8srx/iGzjSR4XPzekZPS5 DQfOSKywiAtnqJepKKg+ZTkh3RVmlDsliJUBIepXxLwo5bMhqSgi0LqoO1+Y8Vrtp3yROuck2qi R4b/zYdW+YZfKzmuZiUdy0n3JfGjK+oNe5WtNYeUICuvxJz0mdR5gYGTia+ykn0xsUz97P4OOGl GbfF7vttqD80Neqq1ihbjLnoLk7rtfjkEyVaZ/FrbuGnSp3bNd2v3QtLT7y2A5JoFCVkekRrJqb S4ctq/p/21ks6LzYnZVuB4I6TMb90Kxr0Q== X-Received: by 2002:a05:6214:449e:b0:917:8c2d:4283 with SMTP id 6a1803df08f44-920fd36e10bmr57938796d6.22.1794948007115; Tue, 17 Nov 2026 12:40:07 -0800 (PST) Received: from localhost ([2600:4040:9399:4000:e553:72e5:7d37:c7ef]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-92114db5db5sm2876646d6.43.2026.11.17.12.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 12:40:06 -0800 (PST) X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Nov 2026 15:40:02 -0500 Message-Id: From: "Daniel Zahka" To: "Stan Iliev" , "Tony Nguyen" , "Przemek Kitszel" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Andrew Lunn" , Cc: , , "David Decotigny" , "Madhu Chittim" , "Emil Tantilov" , "Sridhar Samudrala" , "Brian Vazquez" , "Li Li" , "Alexander Lobakin" , "Daniel Zahka" , "Willem de Bruijn" , "Kees Cook" , "Gustavo A. R. Silva" , Subject: Re: [PATCH iwl-next 07/15] idpf: psp: add support for fips compliance status X-Mailer: aerc 0.21.0-threadmapfix References: <20261117145522.1910636-1-stani@google.com> <20261117145522.1910636-8-stani@google.com> In-Reply-To: <20261117145522.1910636-8-stani@google.com> On Tue Nov 17, 2026 at 9:55 AM EST, Stan Iliev wrote: > Add support for querying the FIPS compliance status of the crypto > offload: > - Introduce VIRTCHNL2_OP_GET_FIPS_COMPLIANCE_STATUS (567) and > struct virtchnl2_get_fips_compliance_status_resp. > - Implement idpf_send_get_fips_compliance_status(), called from > idpf_psp_init(), which logs the status as > "compliant@cmvp_cert__and_" or "noncompliant". The status is > informational only: failing to read it doesn't disable PSP. > > Signed-off-by: Stan Iliev > --- [...] > + > +/** > + * idpf_send_get_fips_compliance_status - Get the FIPS compliance status > + * @adapter: Driver specific private structure > + * > + * Query the FIPS compliance status of the crypto offload with > + * VIRTCHNL2_OP_GET_FIPS_COMPLIANCE_STATUS and log it in the legacy > + * "compliant@cmvp_cert__and_" form, or as "noncompliant". > + * > + * Return: 0 on success, negative on failure. > + */ > +int idpf_send_get_fips_compliance_status(struct idpf_adapter *adapter) > +{ > + struct libie_ctlq_xn_send_params xn_params =3D { > + .chnl_opcode =3D VIRTCHNL2_OP_GET_FIPS_COMPLIANCE_STATUS, > + .timeout_ms =3D IDPF_VC_XN_DEFAULT_TIMEOUT_MSEC, > + }; > + const struct virtchnl2_get_fips_compliance_status_resp *resp; > + struct device *dev =3D &adapter->pdev->dev; > + char status[128]; > + size_t reply_sz; > + u32 num_certs; > + int len, err; > + /* The request has no payload, but libie can't send empty messages */ > + u8 dummy =3D 0; > + u32 i; > + > + err =3D idpf_send_mb_msg(adapter, &xn_params, &dummy, sizeof(dummy)); > + if (err) > + return err; > + > + reply_sz =3D xn_params.recv_mem.iov_len; > + resp =3D xn_params.recv_mem.iov_base; > + if (reply_sz < sizeof(*resp)) { > + err =3D -EIO; > + goto release_rx; > + } > + > + num_certs =3D le32_to_cpu(resp->num_certs); > + if (struct_size(resp, certs, num_certs) > reply_sz) { > + err =3D -EIO; > + goto release_rx; > + } > + > + if (!num_certs) { > + dev_info(dev, "PSP FIPS compliance: noncompliant\n"); > + goto release_rx; > + } > + > + len =3D scnprintf(status, sizeof(status), "compliant@cmvp_cert_"); > + for (i =3D 0; i < num_certs; i++) > + len +=3D scnprintf(status + len, sizeof(status) - len, "%s%u", > + i ? "_and_" : "", le32_to_cpu(resp->certs[i])); > + dev_info(dev, "PSP FIPS compliance: %s\n", status); > + You should think about exposing this with a netlink uapi instead of making userspace parse it from dmesg. Maybe PSP dev-get. I would also suggest moving this to a series after the PSP implementation. It doesn't make sense to have the PSP driver API implemented over the span of two separate series when stuff like this is in between. > +release_rx: > + libie_ctlq_release_rx_buf(&xn_params.recv_mem); > + return err; > +}