From: Andy Shevchenko <andy@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev, linux-efi@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] wcslen() prototype in string.h
Date: Wed, 26 Mar 2025 10:52:51 +0200 [thread overview]
Message-ID: <Z-PAY6t3NYCbgXpa@smile.fi.intel.com> (raw)
In-Reply-To: <20250325214516.GA672870@ax162>
On Tue, Mar 25, 2025 at 02:45:16PM -0700, Nathan Chancellor wrote:
> On Tue, Mar 25, 2025 at 07:05:28PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 25, 2025 at 09:58:47AM -0700, Nathan Chancellor wrote:
> > > On Tue, Mar 25, 2025 at 06:17:34PM +0200, Andy Shevchenko wrote:
> > > > On Tue, Mar 25, 2025 at 08:45:19AM -0700, Nathan Chancellor wrote:
...
> > > > > Rename the efi function to avoid the conflict.
> > > >
> > > > Hmm... Why not split this to two, rename patch as a standalone makes sense to
> > > > me even outside of this series.
> > >
> > > How so? If nls.h is not included in printk.c via string.h, which does
> > > not happen without this series, what value does the rename have? I do
> > > not mind splitting it up that way to keep things cleaner, I am just
> > > wondering what would be the justification in the changelog (I guess just
> > > that nls.h may get included in the future for some reason)?
> >
> > Inside this series the justification is obvious (a.k.a. the same), outside
> > yes something like "Put EFI specific function to the respective namespace
> > to avoid potential clash in the future when including another header."
>
> Okay, sounds reasonable to me. This is what I ended up with for that
> change, which will become patch one of the series.
LGTM.
However, now I'm thinking about nls.h appearing in the string.h.
The former actually lacks two headers in it: module.h and types.h.
I'm wondering if fixing nls.h would be even possible after your series.
> with basically the same changelog.
>
> I will send v2 either tomorrow afternoon or Thursday morning to give a
> little more time for initial review/comments.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-03-26 8:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 15:45 [PATCH 0/2] string.c: Add wcslen() Nathan Chancellor
2025-03-25 15:45 ` [PATCH 1/2] lib/string.c: " Nathan Chancellor
2025-03-25 15:45 ` [PATCH RFC 2/2] wcslen() prototype in string.h Nathan Chancellor
2025-03-25 16:17 ` Andy Shevchenko
2025-03-25 16:58 ` Nathan Chancellor
2025-03-25 17:05 ` Andy Shevchenko
2025-03-25 21:45 ` Nathan Chancellor
2025-03-26 0:33 ` Nathan Chancellor
2025-03-26 8:59 ` Andy Shevchenko
2025-03-26 15:37 ` Nathan Chancellor
2025-03-26 15:43 ` Andy Shevchenko
2025-03-26 8:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-PAY6t3NYCbgXpa@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=ardb@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).