From: Breno Leitao <leitao@debian.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Simon Horman <horms@kernel.org>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] netdevice: define and allocate &net_device _properly_
Date: Fri, 14 Jun 2024 05:00:54 -0700 [thread overview]
Message-ID: <Zmww9tS2eWt3mnj3@gmail.com> (raw)
In-Reply-To: <3b08e1d0-62be-4fae-9dbb-9161992ee067@intel.com>
On Wed, May 08, 2024 at 11:13:21AM +0200, Alexander Lobakin wrote:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Tue, 7 May 2024 11:10:35 -0700
>
> > On Tue, 7 May 2024 14:39:37 +0200 Alexander Lobakin wrote:
> >> There are several instances of the structure embedded into other
> >> structures, but also there's ongoing effort to remove them and we
> >> could in the meantime declare &net_device properly.
> >
> > Is there a reason you're reposting this before that effort is completed?
>
> To speed up the conversion probably :D
>
> > The warnings this adds come from sparse and you think they should be
> > ignored?
>
> For now...
>
> >
> > TBH since Breno is doing the heavy lifting of changing the embedders
> > it'd seem more fair to me if he got to send this at the end. Or at
> > least, you know, got a mention or a CC.
>
> I was lazy enough to add tags, sorry. The idea of him sending this at
> the end sounds reasonable.
I think we are almost at the time to get rid of the last user of
embedded netdev.
https://lore.kernel.org/all/20240614115317.657700-1-leitao@debian.org/
Once that patch lands, I will submit this patch on top of that final
fix.
Let me know if you have any concern.
--breno
next prev parent reply other threads:[~2024-06-14 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:39 [PATCH net-next] netdevice: define and allocate &net_device _properly_ Alexander Lobakin
2024-05-07 15:30 ` Przemek Kitszel
2024-05-07 18:10 ` Jakub Kicinski
2024-05-08 9:13 ` Alexander Lobakin
2024-06-14 12:00 ` Breno Leitao [this message]
2024-06-21 13:11 ` Breno Leitao
2024-05-07 18:21 ` Eric Dumazet
2024-05-08 9:10 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmww9tS2eWt3mnj3@gmail.com \
--to=leitao@debian.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).