From: Sabrina Dubroca <sd@queasysnail.net>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] tls: Avoid -Wflex-array-member-not-at-end warning
Date: Wed, 24 Sep 2025 22:18:08 +0200 [thread overview]
Message-ID: <aNRSACsf_h3ePDhf@krikkit> (raw)
In-Reply-To: <aNMG1lyXw4XEAVaE@kspp>
Thanks for the updated patch.
A process nit: the correct subject prefix for this type of work within
networking would be [PATCH net-next v2] (indicating it targets the
"net-next" tree).
2025-09-23, 22:45:10 +0200, Gustavo A. R. Silva wrote:
> Remove unused flexible-array member in struct tls_rec and, with this,
> fix the following warning:
>
> net/tls/tls.h:131:29: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
>
> Also, add a comment to prevent people from adding any members
> after struct aead_request, which is a flexible structure --this is
> a structure that ends in a flexible-array member.
Once that warning is enabled, re-adding a field after aead_req will
not be allowed by the compiler, right? The comment is probably not
really needed, but since there are "must be first" comments all over
include/net, I guess it's useful.
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2025-09-24 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 20:45 [PATCH v2][next] tls: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-09-24 20:18 ` Sabrina Dubroca [this message]
2025-09-25 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNRSACsf_h3ePDhf@krikkit \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).