Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()

Nicolas Schier
2025-12-20T12:55:19Z

On Sat, Dec 20, 2025 at 12:02:21PM +0100, Vincent Mailhol wrote:
> The is_non_negative() and is_negative() function-like macros just
> exist as a workaround to silence the -Wtype-limits warning. Now that
> this warning is disabled, those two macros have lost their raison
> d'être. Remove them.
>
> This reverts commit dc7fe518b049 ("overflow: Fix -Wtype-limits
> compilation warnings").
>
> Suggested-by: Nicolas Schier <nsc@kernel.org>
> Link: https://lore.kernel.org/all/aUT_yWin_xslnOFh@derry.ads.avm.de
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
> ---
> Changelog:
>
> v1 -> v2: new patch
> ---
> include/linux/overflow.h | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>

Thanks!

Reviewed-by: Nicolas Schier <nsc@kernel.org>