Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()

Vincent Mailhol
2026-01-02T22:26:43Z

On 02/01/2026 at 12:04, Miguel Ojeda wrote:
> On Thu, Jan 1, 2026 at 9:13 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
>>
>> thanks! I think it's a bit sad to keep code only to make some checker
>> tooling happy, but for now it seems to be the right thing to do.
>
> Perhaps a patch to add a comment explaining Vincent's findings would
> be a good outcome, i.e. explaining the reason it needs to remain in
> place for the moment

OK. But I will send this as a separate patch as a reply to this thread
so that this can be discussed separately without having to respin the
main series again and again. I will add it back to the main series only
if it get a decent level of Acked-by tags.

> (even a link to lore.kernel.org to this thread would help).

It is rather uncommon to add lore.kernel.org links in the code comment.
But I am not against. I will do as you suggested so and see what people
think of it.

Yours sincerely,
Vincent Mailhol