From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Feng Jiang <jiangfeng@kylinos.cn>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, kees@kernel.org, andy@kernel.org,
ebiggers@kernel.org, martin.petersen@oracle.com, Jason@zx2c4.com,
conor.dooley@microchip.com, samuel.holland@sifive.com,
charlie@rivosinc.com, ajones@ventanamicro.com, nathan@kernel.org,
linus.walleij@linaro.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/5] lib/string_kunit: add test case for strnlen
Date: Thu, 8 Jan 2026 09:26:59 +0200 [thread overview]
Message-ID: <aV9cQ2QMA-jwFNUO@smile.fi.intel.com> (raw)
In-Reply-To: <b419c6db-0f3f-4666-8f7c-156f7eda2b5b@kylinos.cn>
On Thu, Jan 08, 2026 at 02:53:58PM +0800, Feng Jiang wrote:
> On 2026/1/7 19:56, Andy Shevchenko wrote:
> > On Wed, Jan 7, 2026 at 4:35 AM Feng Jiang <jiangfeng@kylinos.cn> wrote:
...
> >> Add a KUnit test for strnlen() to verify correctness across
> >> different string lengths and memory alignments.
> >
> > Same comment as per patch 1 (it would probably require to call for
> > arch_strnlen() or something like this).
>
> Thanks, makes sense.
>
> I'll add the performance benchmarking (random filling + timing) in V2.
>
> Since string functions are typically exported directly by each architecture
> without an arch_ prefix, I'll introduce a generic_strnlen() (based on
> lib/string.c) within the test for comparison.
Probably you want to make the existing one to have that name and use it inside
the test and in the fallback wrapper. We don't want to have duplicate code, it
is bad from maintenance perspective.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-08 7:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 2:35 [PATCH 0/5] riscv: optimize string functions and add kunit tests Feng Jiang
2026-01-07 2:35 ` [PATCH 1/5] lib/string_kunit: add test case for strlen Feng Jiang
2026-01-07 11:48 ` Andy Shevchenko
2026-01-07 2:35 ` [PATCH 2/5] lib/string_kunit: add test case for strnlen Feng Jiang
2026-01-07 11:56 ` Andy Shevchenko
2026-01-08 6:53 ` Feng Jiang
2026-01-08 7:26 ` Andy Shevchenko [this message]
2026-01-08 10:00 ` Feng Jiang
2026-01-08 10:42 ` Andy Shevchenko
2026-01-07 2:35 ` [PATCH 3/5] riscv: lib: add strnlen implementation Feng Jiang
2026-01-07 2:35 ` [PATCH 4/5] riscv: lib: add strchr implementation Feng Jiang
2026-01-07 2:35 ` [PATCH 5/5] riscv: lib: add strrchr implementation Feng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV9cQ2QMA-jwFNUO@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jason@zx2c4.com \
--cc=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=ebiggers@kernel.org \
--cc=jiangfeng@kylinos.cn \
--cc=kees@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox